Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

dns: default to verbatim=true in dns.lookup()#39987

Closed
treysis wants to merge 18 commits intonodejs:masterfrom
treysis:verbatim-true-v17
Closed

dns: default to verbatim=true in dns.lookup()#39987
treysis wants to merge 18 commits intonodejs:masterfrom
treysis:verbatim-true-v17

Conversation

Copy link
Contributor

treysis commented Sep 3, 2021 *
edited
Loading

Switch the default from false (reorder the result so that IPv4 addresses
come before IPv6 addresses) to true (return them exactly as the resolver
sent them to us.)

After having the option to manually override the default behavior, this is another attempt at changing the default behavior.

Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Reissue of #31567
Reissue of #37681
Reissue of #37931

bricss, DasSkelett, miyurusankalpa, multimikael, and Dzhuneyt reacted with thumbs up emoji
nodejs-github-bot added dns Issues and PRs related to the dns subsystem. needs-ci PRs that need a full CI run. labels Sep 3, 2021
treysis force-pushed the verbatim-true-v17 branch 4 times, most recently from 879d1ff to e37e2be Compare September 3, 2021 20:40
bnoordhuis and others added 2 commits September 3, 2021 22:43
Switch the default from false (reorder the result so that IPv4 addresses
come before IPv6 addresses) to true (return them exactly as the resolver
sent them to us.)

Fixes: nodejs#31566
Refs: nodejs#6307
Refs: nodejs#20710
Refs: nodejs#38099
Reissue of nodejs#31567
Reissue of nodejs#37681
Reissue of nodejs#37931
treysis force-pushed the verbatim-true-v17 branch from e37e2be to acdfa26 Compare September 3, 2021 20:44
aduh95 reviewed Sep 3, 2021
aduh95 added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 3, 2021
Copy link
Contributor Author

treysis commented Sep 3, 2021

Now again we have some failing tests. Do you think I should remove where appropriate to listen on 127.0.0.1 an just listen "generally"? Or force listening on 127.0.0.1 and force connect on 127.0.0.1?

Copy link
Contributor Author

treysis commented Sep 4, 2021

Oooh, my careless mistakes. Let's hope it turns green after this run so we can spin up a CI job.

Copy link
Contributor Author

treysis commented Sep 4, 2021

Alright, can we get a CI @aduh95 ?

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2021
github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2021
Copy link
Collaborator

nodejs-github-bot commented Sep 4, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39778/
treysis reacted with thumbs up emoji

Copy link
Contributor Author

treysis commented Sep 5, 2021 *
edited
Loading

Can we get a CI already before passing the other checks? Because I just need to see why some stuff is failing on CI @aduh95
I'll fix the linter errors before, though.

Copy link

starball5 commented Mar 19, 2023

hardillb mentioned this pull request Mar 29, 2023
evanjd mentioned this pull request May 10, 2023
3 tasks
Keith-CY mentioned this pull request May 11, 2023
smonn mentioned this pull request Jun 7, 2023
1 task
oMoMa mentioned this pull request Jun 19, 2023
zawata mentioned this pull request Nov 15, 2023
BrandonGillis mentioned this pull request Dec 5, 2023
prantlf mentioned this pull request Mar 3, 2024
kt3k mentioned this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes

jasnell jasnell approved these changes

mhdawson mhdawson approved these changes

aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dns Issues and PRs related to the dns subsystem. semver-major PRs that contain breaking changes and should be released in the next major version. tsc-agenda Issues and PRs to discuss during the meetings of the TSC.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dns: default to verbatim=true in dns.lookup()

9 participants