Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

dns: default to verbatim=true in dns.lookup()#20710

Closed
bnoordhuis wants to merge 3 commits intonodejs:masterfrom
bnoordhuis:dns-lookup-verbatim-true
Closed

dns: default to verbatim=true in dns.lookup()#20710
bnoordhuis wants to merge 3 commits intonodejs:masterfrom
bnoordhuis:dns-lookup-verbatim-true

Conversation

Copy link
Member

bnoordhuis commented May 14, 2018

Switch the default from false (reorder the result so that IPv4 addresses
come before IPv6 addresses) to true (return them exactly as the resolver
sent them to us.)

This is intended to be released in Node.js 11.

bnoordhuis added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 14, 2018
nodejs-github-bot added the dns Issues and PRs related to the dns subsystem. label May 14, 2018
addaleax approved these changes May 14, 2018
doc/api/dns.md Outdated
Copy link
Contributor

vsemozhetbyt May 14, 2018 *
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: a period after `true` for consistency with the previous option.

BridgeAR and trivikr reacted with thumbs up emoji
Copy link
Member

BridgeAR May 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that can also be done why landing the PR.

cjihrig approved these changes May 14, 2018
BridgeAR approved these changes May 14, 2018
trivikr approved these changes May 14, 2018
jasnell approved these changes May 14, 2018
lpinca approved these changes May 14, 2018
BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 15, 2018
Copy link
Member

BridgeAR commented May 15, 2018 *
edited
Loading

CI https://ci.nodejs.org/job/node-test-pull-request/14880/

Please address the nit while landing.

BridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 18, 2018
Copy link
Member

BridgeAR commented May 18, 2018

There are lots of related CI failures.

bnoordhuis force-pushed the dns-lookup-verbatim-true branch from f1945c9 to 91e03fe Compare May 18, 2018 12:49
Copy link
Member Author

bnoordhuis commented May 18, 2018

I kinda expected that, I was pretty sure the test suite would be full of assumptions about localhost. I fixed them, PTAL. I also removed common.localhostIPv4, see the commit log for rationale.

https://ci.nodejs.org/job/node-test-pull-request/14958/

BridgeAR approved these changes May 18, 2018
Copy link
Member

BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green.

BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. wip Issues and PRs that are still a work in progress. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 18, 2018
Copy link
Member

jasnell commented May 23, 2018

Needs a rebase and another CI run after.

bnoordhuis force-pushed the dns-lookup-verbatim-true branch from 91e03fe to b173c9e Compare May 28, 2018 20:50
Copy link
Member

BridgeAR commented May 29, 2018

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 29, 2018
Copy link
Member Author

bnoordhuis commented May 29, 2018

Thanks, Ruben. Looks like there are still some tests to fix up...
BridgeAR reacted with thumbs up emoji

BridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 29, 2018
Copy link
Member

jasnell commented Aug 12, 2018

ping @bnoordhuis

jasnell added the stalled Issues and PRs that are stalled. label Oct 17, 2018
Copy link
Member

jasnell commented Oct 17, 2018

ping @bnoordhuis

sam-github approved these changes Oct 17, 2018
Trott added this to the 12.0.0 milestone Nov 29, 2018
treysis pushed a commit to treysis/io.js that referenced this pull request Mar 10, 2021
Switch the default from false (reorder the result so that IPv4 addresses
come before IPv6 addresses) to true (return them exactly as the resolver
sent them to us.)

Fixes: nodejs#31566
Refs: nodejs#6307
Refs: nodejs#20710
Reissue of nodejs#31567
treysis pushed a commit to treysis/io.js that referenced this pull request Mar 13, 2021
Switch the default from false (reorder the result so that IPv4 addresses
come before IPv6 addresses) to true (return them exactly as the resolver
sent them to us.)

Fixes: nodejs#31566
Refs: nodejs#6307
Refs: nodejs#20710
Reissue of nodejs#31567
treysis mentioned this pull request Mar 26, 2021
treysis pushed a commit to treysis/io.js that referenced this pull request Mar 26, 2021
Switch the default from false (reorder the result so that IPv4 addresses
come before IPv6 addresses) to true (return them exactly as the resolver
sent them to us.)

Fixes: nodejs#31566
Refs: nodejs#6307
Refs: nodejs#20710
Reissue of nodejs#31567
Reissue of nodejs#37681
oyyd mentioned this pull request Apr 5, 2021
treysis pushed a commit to treysis/io.js that referenced this pull request Sep 3, 2021
Switch the default from false (reorder the result so that IPv4 addresses
come before IPv6 addresses) to true (return them exactly as the resolver
sent them to us.)

Fixes: nodejs#31566
Refs: nodejs#6307
Refs: nodejs#20710
Reissue of nodejs#31567
Reissue of nodejs#37681
Reissue of nodejs#37931
treysis mentioned this pull request Sep 3, 2021
treysis pushed a commit to treysis/io.js that referenced this pull request Sep 3, 2021
Switch the default from false (reorder the result so that IPv4 addresses
come before IPv6 addresses) to true (return them exactly as the resolver
sent them to us.)

Fixes: nodejs#31566
Refs: nodejs#6307
Refs: nodejs#20710
Reissue of nodejs#31567
Reissue of nodejs#37681
Reissue of nodejs#37931
treysis pushed a commit to treysis/io.js that referenced this pull request Sep 3, 2021
Switch the default from false (reorder the result so that IPv4 addresses
come before IPv6 addresses) to true (return them exactly as the resolver
sent them to us.)

Fixes: nodejs#31566
Refs: nodejs#6307
Refs: nodejs#20710
Reissue of nodejs#31567
Reissue of nodejs#37681
Reissue of nodejs#37931
treysis pushed a commit to treysis/io.js that referenced this pull request Sep 3, 2021
Switch the default from false (reorder the result so that IPv4 addresses
come before IPv6 addresses) to true (return them exactly as the resolver
sent them to us.)

Fixes: nodejs#31566
Refs: nodejs#6307
Refs: nodejs#20710
Refs: nodejs#38099
Reissue of nodejs#31567
Reissue of nodejs#37681
Reissue of nodejs#37931
nodejs-github-bot pushed a commit that referenced this pull request Sep 12, 2021
Switch the default from false (reorder the result so that IPv4 addresses
come before IPv6 addresses) to true (return them exactly as the resolver
sent them to us.)

Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Reissue of #31567
Reissue of #37681
Reissue of #37931

PR-URL: #39987
Refs: #6307
Refs: #20710
Refs: #38099
Reviewed-By: Antoine du Hamel
Reviewed-By: Matteo Collina
Reviewed-By: James M Snell
Reviewed-By: Michael Dawson
nodejs-github-bot pushed a commit that referenced this pull request Sep 12, 2021
PR-URL: #39987
Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Reviewed-By: Antoine du Hamel
Reviewed-By: Matteo Collina
Reviewed-By: James M Snell
Reviewed-By: Michael Dawson
nodejs-github-bot pushed a commit that referenced this pull request Sep 12, 2021
PR-URL: #39987
Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Reviewed-By: Antoine du Hamel
Reviewed-By: Matteo Collina
Reviewed-By: James M Snell
Reviewed-By: Michael Dawson
nodejs-github-bot pushed a commit that referenced this pull request Sep 12, 2021
PR-URL: #39987
Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Reviewed-By: Antoine du Hamel
Reviewed-By: Matteo Collina
Reviewed-By: James M Snell
Reviewed-By: Michael Dawson
nodejs-github-bot pushed a commit that referenced this pull request Sep 12, 2021
PR-URL: #39987
Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Reviewed-By: Antoine du Hamel
Reviewed-By: Matteo Collina
Reviewed-By: James M Snell
Reviewed-By: Michael Dawson
nodejs-github-bot pushed a commit that referenced this pull request Sep 12, 2021
PR-URL: #39987
Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Reviewed-By: Antoine du Hamel
Reviewed-By: Matteo Collina
Reviewed-By: James M Snell
Reviewed-By: Michael Dawson
nodejs-github-bot pushed a commit that referenced this pull request Sep 12, 2021
PR-URL: #39987
Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Reviewed-By: Antoine du Hamel
Reviewed-By: Matteo Collina
Reviewed-By: James M Snell
Reviewed-By: Michael Dawson
nodejs-github-bot pushed a commit that referenced this pull request Sep 12, 2021
PR-URL: #39987
Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Reviewed-By: Antoine du Hamel
Reviewed-By: Matteo Collina
Reviewed-By: James M Snell
Reviewed-By: Michael Dawson
nodejs-github-bot pushed a commit that referenced this pull request Sep 12, 2021
PR-URL: #39987
Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Reviewed-By: Antoine du Hamel
Reviewed-By: Matteo Collina
Reviewed-By: James M Snell
Reviewed-By: Michael Dawson
nodejs-github-bot pushed a commit that referenced this pull request Sep 12, 2021
PR-URL: #39987
Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Reviewed-By: Antoine du Hamel
Reviewed-By: Matteo Collina
Reviewed-By: James M Snell
Reviewed-By: Michael Dawson
nodejs-github-bot pushed a commit that referenced this pull request Sep 12, 2021
PR-URL: #39987
Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Reviewed-By: Antoine du Hamel
Reviewed-By: Matteo Collina
Reviewed-By: James M Snell
Reviewed-By: Michael Dawson
nodejs-github-bot pushed a commit that referenced this pull request Sep 12, 2021
PR-URL: #39987
Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Reviewed-By: Antoine du Hamel
Reviewed-By: Matteo Collina
Reviewed-By: James M Snell
Reviewed-By: Michael Dawson
nodejs-github-bot pushed a commit that referenced this pull request Sep 12, 2021
PR-URL: #39987
Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Reviewed-By: Antoine du Hamel
Reviewed-By: Matteo Collina
Reviewed-By: James M Snell
Reviewed-By: Michael Dawson
nodejs-github-bot pushed a commit that referenced this pull request Sep 12, 2021
PR-URL: #39987
Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Reviewed-By: Antoine du Hamel
Reviewed-By: Matteo Collina
Reviewed-By: James M Snell
Reviewed-By: Michael Dawson
nodejs-github-bot pushed a commit that referenced this pull request Sep 12, 2021
PR-URL: #39987
Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Reviewed-By: Antoine du Hamel
Reviewed-By: Matteo Collina
Reviewed-By: James M Snell
Reviewed-By: Michael Dawson
nodejs-github-bot pushed a commit that referenced this pull request Sep 12, 2021
PR-URL: #39987
Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Reviewed-By: Antoine du Hamel
Reviewed-By: Matteo Collina
Reviewed-By: James M Snell
Reviewed-By: Michael Dawson
nodejs-github-bot pushed a commit that referenced this pull request Sep 12, 2021
PR-URL: #39987
Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Reviewed-By: Antoine du Hamel
Reviewed-By: Matteo Collina
Reviewed-By: James M Snell
Reviewed-By: Michael Dawson
nodejs-github-bot pushed a commit that referenced this pull request Sep 12, 2021
Co-authored-by: Antoine du Hamel

PR-URL: #39987
Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Reviewed-By: Antoine du Hamel
Reviewed-By: Matteo Collina
Reviewed-By: James M Snell
Reviewed-By: Michael Dawson
aduh95 pushed a commit that referenced this pull request Sep 12, 2021
Switch the default from `ipv4first` to `verbatim` (return them exactly
as the resolver sent them to us).

PR-URL: #39987
Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Reviewed-By: Antoine du Hamel
Reviewed-By: Matteo Collina
Reviewed-By: James M Snell
Reviewed-By: Michael Dawson
aduh95 pushed a commit that referenced this pull request Sep 12, 2021
Switch the default from `ipv4first` to `verbatim` (return them exactly
as the resolver sent them to us).

PR-URL: #39987
Fixes: #31566
Refs: #6307
Refs: #20710
Refs: #38099
Co-authored-by: treysis
Reviewed-By: Antoine du Hamel
Reviewed-By: Matteo Collina
Reviewed-By: James M Snell
Reviewed-By: Michael Dawson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes

addaleax addaleax approved these changes

lpinca lpinca approved these changes

cjihrig cjihrig approved these changes

BridgeAR BridgeAR approved these changes

trivikr trivikr approved these changes

+2 more reviewers

vsemozhetbyt vsemozhetbyt left review comments

sam-github sam-github approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dns Issues and PRs related to the dns subsystem. semver-major PRs that contain breaking changes and should be released in the next major version. stalled Issues and PRs that are stalled. wip Issues and PRs that are still a work in progress.

Projects

None yet

Milestone

12.0.0

Development

Successfully merging this pull request may close these issues.