Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(hitl): allow filtering by taskIdPattern in "GET /hitlDetails"#53923

Merged
Lee-W merged 1 commit intoapache:mainfrom
astronomer:filter-ti-in-getting-hitl-details
Jul 31, 2025
Merged

feat(hitl): allow filtering by taskIdPattern in "GET /hitlDetails"#53923
Lee-W merged 1 commit intoapache:mainfrom
astronomer:filter-ti-in-getting-hitl-details

Conversation

Copy link
Member

Lee-W commented Jul 30, 2025 *
edited
Loading

Why

needed by #53035

What

allow filtering by taskIdPattern in "GET /hitlDetails"


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Lee-W requested review from bugraoz93, ephraimbuddy, jason810496, pierrejeambrun, rawwar and shubhamraj-git as code owners July 30, 2025 11:11
boring-cyborg bot added the area:API Airflow's REST/HTTP API label Jul 30, 2025
Lee-W changed the title feat(hitl): allow filtering by taskId in "GET /hitlDetails" feat(hitl): allow filtering by taskIdPattern in "GET /hitlDetails" Jul 30, 2025
Lee-W mentioned this pull request Jul 30, 2025
Lee-W force-pushed the filter-ti-in-getting-hitl-details branch from 466363d to 4f56705 Compare July 30, 2025 11:18
Lee-W added this to AIP-90 - Human in the loop Jul 30, 2025
Lee-W moved this to In review in AIP-90 - Human in the loop Jul 30, 2025
Lee-W requested a review from jscheffl July 30, 2025 11:19
Lee-W self-assigned this Jul 30, 2025
jason810496 approved these changes Jul 30, 2025
Copy link
Member

jason810496 left a comment *
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

However, the CI needs fix.
It seems like the OpenAPI spec generated by pre-commit need to be re-generated.

pre-commit run generate-openapi-spec --all

Lee-W force-pushed the filter-ti-in-getting-hitl-details branch from 4f56705 to c4691c5 Compare July 30, 2025 12:46
Copy link
Member Author

Lee-W commented Jul 30, 2025

Thanks, LGTM!

However, the CI needs fix. It seems like the OpenAPI spec generated by pre-commit need to be re-generated.

pre-commit run generate-openapi-spec --all

Yep, just found out we need to do it on the UI side as well. repush now

Lee-W force-pushed the filter-ti-in-getting-hitl-details branch from c4691c5 to 394e34d Compare July 30, 2025 13:15
Lee-W requested review from bbovenzi and ryanahamilton as code owners July 30, 2025 13:15
Copy link
Member Author

Lee-W commented Jul 30, 2025

Thanks, LGTM!

However, the CI needs fix. It seems like the OpenAPI spec generated by pre-commit need to be re-generated.

pre-commit run generate-openapi-spec --all

Yep, just found out we need to do it on the UI side as well. repush now

bugraoz93 approved these changes Jul 30, 2025
jscheffl approved these changes Jul 30, 2025
Copy link
Contributor

jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Lee-W merged commit d54477f into apache:main Jul 31, 2025
103 checks passed
Lee-W deleted the filter-ti-in-getting-hitl-details branch July 31, 2025 01:43
github-project-automation bot moved this from In review to Done in AIP-90 - Human in the loop Jul 31, 2025
RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Jul 31, 2025
ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 7, 2025
fweilun pushed a commit to fweilun/airflow that referenced this pull request Aug 11, 2025
kaxil added a commit to apache/airflow-client-python that referenced this pull request Oct 22, 2025
(from https://github.com/apache/airflow/tree/python-client/3.1.0rc1)

## New Features:

- Add `map_index` filter to TaskInstance API queries ([#55614](apache/airflow#55614))
- Add `has_import_errors` filter to Core API GET /dags endpoint ([#54563](apache/airflow#54563))
- Add `dag_version` filter to get_dag_runs endpoint ([#54882](apache/airflow#54882))
- Implement pattern search for event log endpoint ([#55114](apache/airflow#55114))
- Add asset-based filtering support to DAG API endpoint ([#54263](apache/airflow#54263))
- Add Greater Than and Less Than range filters to DagRuns and Task Instance list ([#54302](apache/airflow#54302))
- Add `try_number` as filter to task instances ([#54695](apache/airflow#54695))
- Add filters to Browse XComs endpoint ([#54049](apache/airflow#54049))
- Add Filtering by DAG Bundle Name and Version to API routes ([#54004](apache/airflow#54004))
- Add search filter for DAG runs by triggering user name ([#53652](apache/airflow#53652))
- Enable multi sorting (AIP-84) ([#53408](apache/airflow#53408))
- Add `run_on_latest_version` support for backfill and clear operations ([#52177](apache/airflow#52177))
- Add `run_id_pattern` search for Dag Run API ([#52437](apache/airflow#52437))
- Add tracking of triggering user to Dag runs ([#51738](apache/airflow#51738))
- Expose DAG parsing duration in the API ([#54752](apache/airflow#54752))

## New API Endpoints:

- Add Human-in-the-Loop (HITL) endpoints for approval workflows ([#52868](apache/airflow#52868), [#53373](apache/airflow#53373), [#53376](apache/airflow#53376), [#53885](apache/airflow#53885), [#53923](apache/airflow#53923), [#54308](apache/airflow#54308), [#54310](apache/airflow#54310), [#54723](apache/airflow#54723), [#54773](apache/airflow#54773), [#55019](apache/airflow#55019), [#55463](apache/airflow#55463), [#55525](apache/airflow#55525), [#55535](apache/airflow#55535), [#55603](apache/airflow#55603), [#55776](apache/airflow#55776))
- Add endpoint to watch dag run until finish ([#51920](apache/airflow#51920))
- Add TI bulk actions endpoint ([#50443](apache/airflow#50443))
- Add Keycloak Refresh Token Endpoint ([#51657](apache/airflow#51657))

## Deprecations:

- Mark `DagDetailsResponse.concurrency` as deprecated ([#55150](apache/airflow#55150))

## Bug Fixes:

- Fix dag import error modal pagination ([#55719](apache/airflow#55719))
kaxil mentioned this pull request Oct 22, 2025
kaxil added a commit to apache/airflow-client-python that referenced this pull request Oct 23, 2025
(from https://github.com/apache/airflow/tree/python-client/3.1.0rc1)

## New Features:

- Add `map_index` filter to TaskInstance API queries ([#55614](apache/airflow#55614))
- Add `has_import_errors` filter to Core API GET /dags endpoint ([#54563](apache/airflow#54563))
- Add `dag_version` filter to get_dag_runs endpoint ([#54882](apache/airflow#54882))
- Implement pattern search for event log endpoint ([#55114](apache/airflow#55114))
- Add asset-based filtering support to DAG API endpoint ([#54263](apache/airflow#54263))
- Add Greater Than and Less Than range filters to DagRuns and Task Instance list ([#54302](apache/airflow#54302))
- Add `try_number` as filter to task instances ([#54695](apache/airflow#54695))
- Add filters to Browse XComs endpoint ([#54049](apache/airflow#54049))
- Add Filtering by DAG Bundle Name and Version to API routes ([#54004](apache/airflow#54004))
- Add search filter for DAG runs by triggering user name ([#53652](apache/airflow#53652))
- Enable multi sorting (AIP-84) ([#53408](apache/airflow#53408))
- Add `run_on_latest_version` support for backfill and clear operations ([#52177](apache/airflow#52177))
- Add `run_id_pattern` search for Dag Run API ([#52437](apache/airflow#52437))
- Add tracking of triggering user to Dag runs ([#51738](apache/airflow#51738))
- Expose DAG parsing duration in the API ([#54752](apache/airflow#54752))

## New API Endpoints:

- Add Human-in-the-Loop (HITL) endpoints for approval workflows ([#52868](apache/airflow#52868), [#53373](apache/airflow#53373), [#53376](apache/airflow#53376), [#53885](apache/airflow#53885), [#53923](apache/airflow#53923), [#54308](apache/airflow#54308), [#54310](apache/airflow#54310), [#54723](apache/airflow#54723), [#54773](apache/airflow#54773), [#55019](apache/airflow#55019), [#55463](apache/airflow#55463), [#55525](apache/airflow#55525), [#55535](apache/airflow#55535), [#55603](apache/airflow#55603), [#55776](apache/airflow#55776))
- Add endpoint to watch dag run until finish ([#51920](apache/airflow#51920))
- Add TI bulk actions endpoint ([#50443](apache/airflow#50443))
- Add Keycloak Refresh Token Endpoint ([#51657](apache/airflow#51657))

## Deprecations:

- Mark `DagDetailsResponse.concurrency` as deprecated ([#55150](apache/airflow#55150))

## Bug Fixes:

- Fix dag import error modal pagination ([#55719](apache/airflow#55719))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bugraoz93 bugraoz93 approved these changes

jason810496 jason810496 approved these changes

jscheffl jscheffl approved these changes

ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

rawwar Awaiting requested review from rawwar rawwar is a code owner

shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

Assignees

Lee-W

Labels

area:API Airflow's REST/HTTP API

Projects

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants