Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(hitl): include task_instance detail in hitl detail response#53373

Merged
Lee-W merged 4 commits intoapache:mainfrom
astronomer:add-task-instance-detail-to-hitl-detail-response
Jul 16, 2025
Merged

feat(hitl): include task_instance detail in hitl detail response#53373
Lee-W merged 4 commits intoapache:mainfrom
astronomer:add-task-instance-detail-to-hitl-detail-response

Conversation

Copy link
Member

Lee-W commented Jul 15, 2025 *
edited
Loading

Why

Needed by HITL frontend #53035

What

Replace ti_id with task_instance in get hitl detail public api


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Lee-W requested review from XD-DENG, ashb, bugraoz93, ephraimbuddy, jason810496, pierrejeambrun, rawwar and shubhamraj-git as code owners July 15, 2025 13:17
boring-cyborg bot added the area:API Airflow's REST/HTTP API label Jul 15, 2025
Copy link
Member Author

Lee-W commented Jul 15, 2025

cc @guan404ming

guan404ming reacted with rocket emoji

Copy link
Member

guan404ming commented Jul 15, 2025

Thanks! LGTM.

bugraoz93 reviewed Jul 15, 2025
Copy link
Contributor

bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Wei! Could you please run static checks, the datamodel changes needs to be cascaded to airflowctl :)

Copy link
Member Author

Lee-W commented Jul 15, 2025

Looks good, thanks Wei! Could you please run static checks, the datamodel changes needs to be cascaded to airflowctl :)

Sure, I was working on a follow-up PR! let me do it now

bugraoz93 reacted with heart emoji

Lee-W requested review from gopidesupavan and potiuk as code owners July 15, 2025 15:53
Lee-W force-pushed the add-task-instance-detail-to-hitl-detail-response branch from cc77c6e to 86843ad Compare July 15, 2025 17:05
Lee-W requested a review from kaxil as a code owner July 15, 2025 17:05
bugraoz93 approved these changes Jul 15, 2025
Copy link
Member Author

Lee-W commented Jul 15, 2025 *
edited
Loading

Somehow my local cannot generate the spec for some time , but finally got it resolved!

Lee-W force-pushed the add-task-instance-detail-to-hitl-detail-response branch from 86843ad to 9db557b Compare July 16, 2025 06:47
Lee-W requested review from bbovenzi, jscheffl and ryanahamilton as code owners July 16, 2025 06:47
Lee-W force-pushed the add-task-instance-detail-to-hitl-detail-response branch from 9db557b to 9a648f7 Compare July 16, 2025 06:50
Lee-W force-pushed the add-task-instance-detail-to-hitl-detail-response branch from 9a648f7 to d79bbbf Compare July 16, 2025 09:05
Copy link
Member Author

Lee-W commented Jul 16, 2025

green! let's merge it

Lee-W merged commit 7d00376 into apache:main Jul 16, 2025
102 checks passed
Lee-W deleted the add-task-instance-detail-to-hitl-detail-response branch July 16, 2025 10:35
jscheffl reviewed Jul 16, 2025
Copy link
Contributor

jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

kaxil added a commit to apache/airflow-client-python that referenced this pull request Oct 22, 2025
(from https://github.com/apache/airflow/tree/python-client/3.1.0rc1)

## New Features:

- Add `map_index` filter to TaskInstance API queries ([#55614](apache/airflow#55614))
- Add `has_import_errors` filter to Core API GET /dags endpoint ([#54563](apache/airflow#54563))
- Add `dag_version` filter to get_dag_runs endpoint ([#54882](apache/airflow#54882))
- Implement pattern search for event log endpoint ([#55114](apache/airflow#55114))
- Add asset-based filtering support to DAG API endpoint ([#54263](apache/airflow#54263))
- Add Greater Than and Less Than range filters to DagRuns and Task Instance list ([#54302](apache/airflow#54302))
- Add `try_number` as filter to task instances ([#54695](apache/airflow#54695))
- Add filters to Browse XComs endpoint ([#54049](apache/airflow#54049))
- Add Filtering by DAG Bundle Name and Version to API routes ([#54004](apache/airflow#54004))
- Add search filter for DAG runs by triggering user name ([#53652](apache/airflow#53652))
- Enable multi sorting (AIP-84) ([#53408](apache/airflow#53408))
- Add `run_on_latest_version` support for backfill and clear operations ([#52177](apache/airflow#52177))
- Add `run_id_pattern` search for Dag Run API ([#52437](apache/airflow#52437))
- Add tracking of triggering user to Dag runs ([#51738](apache/airflow#51738))
- Expose DAG parsing duration in the API ([#54752](apache/airflow#54752))

## New API Endpoints:

- Add Human-in-the-Loop (HITL) endpoints for approval workflows ([#52868](apache/airflow#52868), [#53373](apache/airflow#53373), [#53376](apache/airflow#53376), [#53885](apache/airflow#53885), [#53923](apache/airflow#53923), [#54308](apache/airflow#54308), [#54310](apache/airflow#54310), [#54723](apache/airflow#54723), [#54773](apache/airflow#54773), [#55019](apache/airflow#55019), [#55463](apache/airflow#55463), [#55525](apache/airflow#55525), [#55535](apache/airflow#55535), [#55603](apache/airflow#55603), [#55776](apache/airflow#55776))
- Add endpoint to watch dag run until finish ([#51920](apache/airflow#51920))
- Add TI bulk actions endpoint ([#50443](apache/airflow#50443))
- Add Keycloak Refresh Token Endpoint ([#51657](apache/airflow#51657))

## Deprecations:

- Mark `DagDetailsResponse.concurrency` as deprecated ([#55150](apache/airflow#55150))

## Bug Fixes:

- Fix dag import error modal pagination ([#55719](apache/airflow#55719))
kaxil mentioned this pull request Oct 22, 2025
kaxil added a commit to apache/airflow-client-python that referenced this pull request Oct 23, 2025
(from https://github.com/apache/airflow/tree/python-client/3.1.0rc1)

## New Features:

- Add `map_index` filter to TaskInstance API queries ([#55614](apache/airflow#55614))
- Add `has_import_errors` filter to Core API GET /dags endpoint ([#54563](apache/airflow#54563))
- Add `dag_version` filter to get_dag_runs endpoint ([#54882](apache/airflow#54882))
- Implement pattern search for event log endpoint ([#55114](apache/airflow#55114))
- Add asset-based filtering support to DAG API endpoint ([#54263](apache/airflow#54263))
- Add Greater Than and Less Than range filters to DagRuns and Task Instance list ([#54302](apache/airflow#54302))
- Add `try_number` as filter to task instances ([#54695](apache/airflow#54695))
- Add filters to Browse XComs endpoint ([#54049](apache/airflow#54049))
- Add Filtering by DAG Bundle Name and Version to API routes ([#54004](apache/airflow#54004))
- Add search filter for DAG runs by triggering user name ([#53652](apache/airflow#53652))
- Enable multi sorting (AIP-84) ([#53408](apache/airflow#53408))
- Add `run_on_latest_version` support for backfill and clear operations ([#52177](apache/airflow#52177))
- Add `run_id_pattern` search for Dag Run API ([#52437](apache/airflow#52437))
- Add tracking of triggering user to Dag runs ([#51738](apache/airflow#51738))
- Expose DAG parsing duration in the API ([#54752](apache/airflow#54752))

## New API Endpoints:

- Add Human-in-the-Loop (HITL) endpoints for approval workflows ([#52868](apache/airflow#52868), [#53373](apache/airflow#53373), [#53376](apache/airflow#53376), [#53885](apache/airflow#53885), [#53923](apache/airflow#53923), [#54308](apache/airflow#54308), [#54310](apache/airflow#54310), [#54723](apache/airflow#54723), [#54773](apache/airflow#54773), [#55019](apache/airflow#55019), [#55463](apache/airflow#55463), [#55525](apache/airflow#55525), [#55535](apache/airflow#55535), [#55603](apache/airflow#55603), [#55776](apache/airflow#55776))
- Add endpoint to watch dag run until finish ([#51920](apache/airflow#51920))
- Add TI bulk actions endpoint ([#50443](apache/airflow#50443))
- Add Keycloak Refresh Token Endpoint ([#51657](apache/airflow#51657))

## Deprecations:

- Mark `DagDetailsResponse.concurrency` as deprecated ([#55150](apache/airflow#55150))

## Bug Fixes:

- Fix dag import error modal pagination ([#55719](apache/airflow#55719))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jscheffl jscheffl left review comments

bugraoz93 bugraoz93 approved these changes

ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

rawwar Awaiting requested review from rawwar rawwar is a code owner

jason810496 Awaiting requested review from jason810496 jason810496 is a code owner

shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

ashb Awaiting requested review from ashb ashb is a code owner

potiuk Awaiting requested review from potiuk potiuk is a code owner

gopidesupavan Awaiting requested review from gopidesupavan gopidesupavan is a code owner

kaxil Awaiting requested review from kaxil

bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

Assignees

No one assigned

Labels

area:API Airflow's REST/HTTP API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants