-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Remove redundant pull_request trigger from IWYU Suggester#85755
Merged
Maleclypse merged 1 commit intoCleverRaven:masterfrom Mar 9, 2026
Merged
Remove redundant pull_request trigger from IWYU Suggester#85755Maleclypse merged 1 commit intoCleverRaven:masterfrom
Maleclypse merged 1 commit intoCleverRaven:masterfrom
Conversation
Contributor
Summary
Infrastructure "Remove redundant pull_request trigger from IWYU Suggester workflow"
Purpose of change
The IWYU Suggester workflow was triggering on both pull_request and pull_request_target events, but the job's if condition only allowed pull_request_target runs through. Every pull_request event created a workflow run that immediately skipped, cluttering the Actions tab.
Also removed the draft PR gate so the suggester runs on drafts too, matching the main IWYU workflow.
Describe the solution
- Removed the
pull_requesttrigger entirely since the job needspull_request_targetfor write permissions anyway - Simplified the concurrency group (no longer need to disambiguate by event name)
- Dropped the
draft == falsecondition from the job
Describe alternatives you've considered
Could have added skip-duplicate-actions like matrix.yml uses, but the root cause was simpler - just a trigger that could never actually run.
Testing
N/A
Additional context
None
github-actions
bot
added
Code: Tooling
Tooling that is not part of the main game but is part of the repo.
Code: Infrastructure / Style / Static Analysis
Code internal infrastructure and style
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.