Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove redundant pull_request trigger from IWYU Suggester#85755

Merged
Maleclypse merged 1 commit intoCleverRaven:masterfrom
dumb-kevin:fix/iwyu-suggester-skips
Mar 9, 2026
Merged

Remove redundant pull_request trigger from IWYU Suggester#85755
Maleclypse merged 1 commit intoCleverRaven:masterfrom
dumb-kevin:fix/iwyu-suggester-skips

Conversation

Copy link
Contributor

dumb-kevin commented Mar 9, 2026

Summary

Infrastructure "Remove redundant pull_request trigger from IWYU Suggester workflow"

Purpose of change

The IWYU Suggester workflow was triggering on both pull_request and pull_request_target events, but the job's if condition only allowed pull_request_target runs through. Every pull_request event created a workflow run that immediately skipped, cluttering the Actions tab.

Also removed the draft PR gate so the suggester runs on drafts too, matching the main IWYU workflow.

Describe the solution

  • Removed the pull_request trigger entirely since the job needs pull_request_target for write permissions anyway
  • Simplified the concurrency group (no longer need to disambiguate by event name)
  • Dropped the draft == false condition from the job

Describe alternatives you've considered

Could have added skip-duplicate-actions like matrix.yml uses, but the root cause was simpler - just a trigger that could never actually run.

Testing

N/A

Additional context

None

github-actions bot added Code: Tooling Tooling that is not part of the main game but is part of the repo. Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 9, 2026
Maleclypse merged commit fa629b9 into CleverRaven:master Mar 9, 2026
22 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants