-
-
Notifications
You must be signed in to change notification settings - Fork 488
Conversation
- Added a
CHANGELOG.mdentry
Summary
Removes ReseedingRng, then reduces the remaining code. Closes #1721.
Motivation
This generic type appears to have little or no real use outside of ThreadRng. Removing it allows for several simplifications (also in rand_core).
Details
(This has a number of little commits so should ultimately be squashed.)
newpavlov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth to also remove bytes_until_reseed and use block counter stored in the ChaCha core as part of this PR.
| - Pub export `Xoshiro128PlusPlus`, `Xoshiro256PlusPlus` prngs (#1649) | ||
| - Pub export `ChaCha8Rng`, `ChaCha12Rng`, `ChaCha20Rng` behind `chacha` feature (#1659) | ||
|
|
||
| ### Removals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keepchangelog recommends to use Added/Changed/Removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the other recent titles match that... a job for another PR.
|
Yes. You can add it as part of RustCrypto/stream-ciphers#512. |
|
Ironically such a method would be one use for keeping the ChaCha*Core types. |
|
The difference is that it's not a "core RNG" type. It's a |
3bee446 to
cc88b38
Compare
This requires bumping chacha20; I'd prefer to use a new PR for that. |
cc88b38 to
76b5b90
Compare