-
-
Notifications
You must be signed in to change notification settings - Fork 35.1k
lib: fix sequence argument handling in Blob constructor#62179
Open
Ms2ger wants to merge 1 commit intonodejs:mainfrom
Open
lib: fix sequence argument handling in Blob constructor#62179Ms2ger wants to merge 1 commit intonodejs:mainfrom
Ms2ger wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
This uses the existing WebIDL infrastructure to handle the iteration
over the argument correctly according to the specification.
Note that we can't avoid looping over the input twice: we only know the
value of the 'endings' option after converting the blob parts into an
array.
over the argument correctly according to the specification.
Note that we can't avoid looping over the input twice: we only know the
value of the 'endings' option after converting the blob parts into an
array.
MattiasBuelens
approved these changes
Mar 10, 2026
Codecov Report All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62179 +/- ## ======================================= Coverage 89.65% 89.65% ======================================= Files 676 676 Lines 206541 206550 +9 Branches 39541 39552 +11 ======================================= + Hits 185171 185182 +11 - Misses 13472 13484 +12 + Partials 7898 7884 -14
New features to boost your workflow:
|
MattiasBuelens
added
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Mar 10, 2026
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Mar 10, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.