Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add Node.js version restrictions#1340

Merged
legendecas merged 1 commit intonodejs:mainfrom
Apollon77:patch-1
Jul 3, 2023
Merged

Add Node.js version restrictions#1340
legendecas merged 1 commit intonodejs:mainfrom
Apollon77:patch-1

Conversation

Copy link
Contributor

Apollon77 commented Jun 16, 2023

Assumed from last Changelog the current version supports Node.js 16, 18, 20 and we should also not block 21+ for now, Right?

fixes #1339

Assumed from last Changelog the current version supports Node.js 16, 18, 20 and we should also not block 21+ for now, Right?
mhdawson approved these changes Jun 30, 2023
Copy link
Member

mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

KevinEady approved these changes Jun 30, 2023
legendecas approved these changes Jul 3, 2023
legendecas merged commit afa494e into nodejs:main Jul 3, 2023
Copy link
Member

legendecas commented Jul 3, 2023

Thank you!
Apollon77 reacted with thumbs up emoji

Copy link

espipj commented Jun 26, 2024

Why was this added in a minor release? This is a breaking change and should have been released in a major version
This breaks for example installing https://github.com/parcel-bundler/watcher on Node 10 to 16...
nikosandronikos reacted with thumbs up emoji

mhdawson mentioned this pull request Jul 5, 2024
legendecas added a commit to legendecas/node-addon-api that referenced this pull request Jul 8, 2024
legendecas mentioned this pull request Jul 8, 2024
legendecas added a commit that referenced this pull request Jul 12, 2024
Copy link
Member

legendecas commented Jul 12, 2024

Why was this added in a minor release? This is a breaking change and should have been released in a major version This breaks for example installing https://github.com/parcel-bundler/watcher on Node 10 to 16...

Released a patch version v7.1.1 to remove the engine requirement. We will still put the constraint on v8.x since we don't test older Node.js versions. Disable engine-strict if a person really want to use it with untested versions.
espipj reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

legendecas legendecas approved these changes

KevinEady KevinEady approved these changes

mhdawson mhdawson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add engines limitation into package.json?

5 participants