-
-
Notifications
You must be signed in to change notification settings - Fork 498
Conversation
*: |
| @@ -0,0 +1,66 @@ | |||
| # SyntaxError | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it say here that it's only supported in node-api version 9 and higher?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so... We don't have any other node-api version information in our docs, eg. Napi::Object::Freeze() does not mention being Node-API v8 only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That might be a gap though ? I go to try to use an API and it's not there? Either way agree that we don't need to be block this PR on it, but might be worth thinking about wether adding that info makes sense.
mhdawson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a suggestion
legendecas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % one nit.
|
|
||
| module.exports = require('./common').runTestWithBindingPath(test); | ||
|
|
||
| const napiVersion = Number(process.env.NAPI_VERSION ?? process.versions.napi); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to move the napiVersion definition in test/index.js to test/common/index.js so that we don't have to repeat it.
|
Added |