-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[Cleanup] Component blueprint cleanup#20773
Merged
ef4 merged 2 commits intoemberjs:mainfrom Oct 18, 2024
Merged
Conversation
Contributor
This removes support for the --component-structure="classic" and --pod arguments from the component blueprint generator.
Part of RFC 995: emberjs/rfcs#1040
Windvis
changed the title
Rfc 995 component blueprint cleanup
[Cleanup] Component blueprint cleanup
Oct 6, 2024
Windvis
commented
Oct 6, 2024
| this.EMBER_GLIMMER_SET_COMPONENT_TEMPLATE && | ||
| commandOptions.componentStructure === 'flat' | ||
| ) { | ||
| if (this.EMBER_GLIMMER_SET_COMPONENT_TEMPLATE && commandOptions.componentStructure === 'flat') { |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the EMBER_GLIMMER_SET_COMPONENT_TEMPLATE code can also be removed but that's unrelated to this PR.
The classic file structure is deprecated.
Windvis
force-pushed
the
rfc-995-component-generator-cleanup
branch
from
October 6, 2024 12:10
0d8919f to
36c9a0f
Compare
The pod layout is deprecated for components.
Windvis
force-pushed
the
rfc-995-component-generator-cleanup
branch
from
October 6, 2024 12:19
36c9a0f to
36242f3
Compare
NullVoxPopuli
approved these changes
Oct 6, 2024
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.