-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Conversation
|
@krisselden is green! |
packages/ember-metal/lib/chains.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we ever delete from this.nodes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, we just empty the array
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stefanpenner should it just search a single array or linked list of well shaped entries? like {key: 'foo', node: node} ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
array should be good, as we just do a sequential scan anyways.
|
@krisselden whats blocking this/ |
packages/ember-metal/lib/chains.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function Empty() {}
Empty.prototype = Object.create(null);
...
this.nodes = new Empty();
4c2cc1f to
95d3f3f
Compare
95d3f3f to
2f63cab
Compare
|
@stefanpenner rebased and squashed |