-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[CLEANUP beta] Remove beforeObserver family from the public API#11796
[CLEANUP beta] Remove beforeObserver family from the public API#11796stefanpenner merged 1 commit intoemberjs:masterfrom
Conversation
- family inclides
Ember.beforeObserver,Ember.addBeforeObserver,
Ember.removeBeforeObserver,Ember.beforeObserversFor,
Ember._suspendBeforeObserver,Ember._suspendBeforeObservers - I noticed that
beforeObserversFor,_suspendBeforeObserverand_suspendBeforeObserves
were not used at all, not even internally. I've also checked for
usages of it in ember-data, liquid-fire and other "official" porjects.
Nothing. So those two are removed completely. - For symetry, I've also removed the
Function.prototype.observesBefore
counterpart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this appears to have have been deprecated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean, it was not deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I mean it did no spew a deprecation warning when used. Is there a sibling PR that introduces that deprecation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, good catch.
@cibernox - We need to land a deprecation for this in release before removing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't. I'll create one. Put this on hold in the meanwhile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`Ember.removeBeforeObserver`, `Ember.beforeObserversFor`,
`Ember._suspendBeforeObserver`, `Ember._suspendBeforeObservers`
* I noticed that `beforeObserversFor`, `_suspendBeforeObserver` and `_suspendBeforeObserves`
were not used at all, not even internally. I've also checked for
usages of it in ember-data, liquid-fire and other "official" porjects.
Nothing. So those two are removed completely.
* For symetry, I've also removed the `Function.prototype.observesBefore`
counterpart.
3011b73 to
75569a9
Compare
|
Rebased |
|
SortableMixin from ember-legacy-controllers breaks as it uses beforeObserver :( |