Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Support for hosting extensions#1653

Open
YAJeff wants to merge 21 commits intodotnet:masterfrom
YAJeff:hosting/hosting-extensions
Open

Support for hosting extensions#1653
YAJeff wants to merge 21 commits intodotnet:masterfrom
YAJeff:hosting/hosting-extensions

Conversation

Copy link
Contributor

YAJeff commented Jan 21, 2023

With this change, the MQTTnet server can be hosted using Microsoft.Extensions.Hosting library, rather than full ASP.net core SDK.

chkr1011 requested changes Feb 3, 2023
@@ -0,0 +1,19 @@
Copy link
Collaborator

chkr1011 Jan 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion we should call this project "MQTTnet.Extensions.Hosting" to fit the other extensions (The Asp library was introduced before the naming pattern was established).

Copy link
Collaborator

chkr1011 Feb 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YAJeff Ping?

Copy link
Contributor Author

YAJeff Feb 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Sorry. I have made those changes internally. Sorry. Been traveling for work. Will check in. There were other changes I've added to make things a little more solid/sound. Will have completed by the end of the weekend.

chkr1011 reacted with thumbs up emoji
chkr1011 requested changes Apr 7, 2023
Copy link
Collaborator

chkr1011 commented Apr 23, 2023

@YAJeff Please agree to the Contributor License. Then I will merge this PR.

Copy link
Contributor

kallayj commented Oct 26, 2023

@dotnet-policy-service agree company="CARIAD Inc"

Copy link
Contributor

kallayj commented Oct 26, 2023

@chkr1011 I've merged the latest from main into @YAJeff's fork and agreed to the CLA on behalf of the company we both work for.

Copy link
Collaborator

chkr1011 commented Nov 4, 2023

@kallayj This does not seem to work. The agreement is still in "Contributor License Agreement is not agreed yet." state. I am afraid you have to create a new PR on your own (or please @YAJeff) to accept it.

Copy link
Contributor Author

YAJeff commented Nov 6, 2023

@dotnet-policy-service agree company="CARIAD Inc"

Copy link
Contributor

kallayj commented Nov 8, 2023

@chkr1011 the CLA check has passed, can this move forward?

Copy link
Collaborator

chkr1011 commented Nov 18, 2023

@kallayj I applied the code style and moved the tests a little around to get the code compiling.

There are still some warnings left and some new properties are not even used. Please let me know when the code is finished so that I can review it.

Copy link
Contributor

kallayj commented Nov 20, 2023

@chkr1011 I addressed the nullable reference type warnings. Where are you seeing unused properties?

Copy link
Collaborator

chkr1011 commented Nov 25, 2023

Please see "MqttServerHostingOptions.WebSocketRoute". It is set but never read. Same for "WebSocketAuthenticationCallback".

chkr1011 and others added 2 commits November 25, 2023 16:24
Copy link
Contributor

kallayj commented Nov 29, 2023

@chkr1011 I removed those properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

chkr1011 chkr1011 requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants