-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
crazy-max
force-pushed
the
scope-auth
branch
2 times, most recently
from
January 8, 2026 11:28
229f7d6 to
a9d4e13
Compare
crazy-max
commented
Jan 8, 2026
Comment on lines
+636
to
+643
| - | ||
| name: Login to registry for signing | ||
| if: ${{ needs.prepare.outputs.sign == 'true' && inputs.output == 'image' }} | ||
| uses: docker/login-action@scope # TODO: pin to a specific version when scope feature is supported | ||
| with: | ||
| registry-auth: ${{ secrets.registry-auths }} | ||
| env: | ||
| DOCKER_LOGIN_SCOPE_DISABLED: true # make sure the scope feature is disabled to avoid interfering with cosign OIDC login |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tonistiigi Needs extra login without scope after build so cosign can use auth from vanilla docker config when signing attestation manifests, otherwise it fails with: https://github.com/docker/github-builder-experimental/actions/runs/20814314320/job/59786046485#step:12:96
Error: Signing BuildKit attestation manifests failed: Cosign sign command failed with errors:
- [UNAUTHORIZED] authentication required : [object Object],[object Object]
Fyi cosign is using google/go-containerregistry to get auth: https://github.com/google/go-containerregistry/blob/e075f209120b2467fd1b7d24727f1890a0edb74a/pkg/authn/keychain.go#L87
crazy-max
force-pushed
the
scope-auth
branch
2 times, most recently
from
January 27, 2026 15:28
bcee16a to
9491fd3
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Member
Author
|
@tonistiigi Ready for review after releasing https://github.com/docker/login-action/releases/tag/v3.7.0 |
tonistiigi
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.