Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[SUREFIRE-2146] Don't draw border around reporting tables#596

Merged
olamy merged 1 commit intomasterfrom
SUREFIRE-2146
Feb 9, 2023
Merged

[SUREFIRE-2146] Don't draw border around reporting tables#596
olamy merged 1 commit intomasterfrom
SUREFIRE-2146

Conversation

Copy link
Member

michael-o commented Jan 26, 2023

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

michael-o requested a review from slawekjaranowski January 26, 2023 18:42
michael-o requested a review from hboutemy February 4, 2023 21:48
olamy added the enhancement New feature or request label Feb 6, 2023
olamy approved these changes Feb 6, 2023
olamy merged commit ee5e81e into master Feb 9, 2023
olamy deleted the SUREFIRE-2146 branch February 9, 2023 08:35
michael-o restored the SUREFIRE-2146 branch February 9, 2023 17:18
michael-o deleted the SUREFIRE-2146 branch February 9, 2023 17:18
michael-o restored the SUREFIRE-2146 branch February 9, 2023 17:18
michael-o deleted the SUREFIRE-2146 branch February 9, 2023 17:18
Copy link

jira-importer commented Jul 4, 2025

Resolve #2832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

olamy olamy approved these changes

slawekjaranowski Awaiting requested review from slawekjaranowski

hboutemy Awaiting requested review from hboutemy

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants