Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(matrix): fix darkMode color#21093

Merged
Ovilia merged 1 commit intomasterfrom
fix-matrix-dark
Jul 10, 2025
Merged

fix(matrix): fix darkMode color#21093
Ovilia merged 1 commit intomasterfrom
fix-matrix-dark

Conversation

Copy link
Contributor

Ovilia commented Jul 9, 2025

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix darkMode color for matrix layout.

Fixed issues

Details

Before: What was the problem?

Borders inside should not have larger contrast with the background than outside borders.

After: How does it behave after the fixing?

Fixed border colors.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

pull-request-size bot added the size/S label Jul 9, 2025
100pah approved these changes Jul 9, 2025
Copy link
Contributor

github-actions bot commented Jul 9, 2025

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21093@769b97e

Ovilia merged commit 25081e5 into master Jul 10, 2025
2 checks passed
Ovilia deleted the fix-matrix-dark branch July 10, 2025 02:24
Ovilia added this to the 6.0.0 milestone Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

100pah 100pah approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

2 participants