-
-
Notifications
You must be signed in to change notification settings - Fork 732
Fix reading the number argument from config file#923
Merged
ericwb merged 2 commits intoPyCQA:mainfrom Jul 7, 2022
Merged
Conversation
When passing the "number" option from the INI file we did
not take into account to store its value as an integer
(when that value is not None).
Resolves: PyCQA#922
not take into account to store its value as an integer
(when that value is not None).
Resolves: PyCQA#922
ericwb
reviewed
Jul 6, 2022
bandit/cli/main.py
Outdated
Comment on lines
515
to
516
| (None if ini_options.get("number") is None | ||
| else int(ini_options.get("number"))), |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| (None if ini_options.get("number") is None | |
| else int(ini_options.get("number"))), | |
| int(ini_options.get("number") or 0) or None, |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, much cleaner!
We use the "or" boolean operation to have a
cleaner implementation of the solution.
cleaner implementation of the solution.
ericwb
approved these changes
Jul 7, 2022
Member
ericwb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.