-
-
Notifications
You must be signed in to change notification settings - Fork 731
Adding tarfile.extractall() plugin with examples#549
Merged
ericwb merged 22 commits intoPyCQA:mainfrom Jul 11, 2022
Merged
Conversation
ericwb
requested changes
Dec 11, 2020
Member
ericwb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From https://docs.python.org/3/library/tarfile.html#tarfile.TarFile.extract, it appears tarfile.extract() has the same issue.
Comment on lines
3
to
13
| # Licensed under the Apache License, Version 2.0 (the "License"); you may | ||
| # not use this file except in compliance with the License. You may obtain | ||
| # a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| # License for the specific language governing permissions and limitations | ||
| # under the License. |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use SPDX short hand form of license header..
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| # Licensed under the Apache License, Version 2.0 (the "License"); you may | |
| # not use this file except in compliance with the License. You may obtain | |
| # a copy of the License at | |
| # | |
| # http://www.apache.org/licenses/LICENSE-2.0 | |
| # | |
| # Unless required by applicable law or agreed to in writing, software | |
| # distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | |
| # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | |
| # License for the specific language governing permissions and limitations | |
| # under the License. |
| - https://docs.python.org/3/library/tarfile.html#tarfile.TarFile.extractall | ||
| - https://docs.python.org/3/library/tarfile.html#tarfile.TarInfo | ||
|
|
||
| .. versionadded:: 1.6.3 |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump to 1.6.4 or next
ericwb
reviewed
Jul 11, 2022
Comment on lines
3
to
13
| # Licensed under the Apache License, Version 2.0 (the "License"); you may | ||
| # not use this file except in compliance with the License. You may obtain | ||
| # a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| # License for the specific language governing permissions and limitations | ||
| # under the License. |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| # Licensed under the Apache License, Version 2.0 (the "License"); you may | |
| # not use this file except in compliance with the License. You may obtain | |
| # a copy of the License at | |
| # | |
| # http://www.apache.org/licenses/LICENSE-2.0 | |
| # | |
| # Unless required by applicable law or agreed to in writing, software | |
| # distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | |
| # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | |
| # License for the specific language governing permissions and limitations | |
| # under the License. |
ericwb
reviewed
Jul 11, 2022
ericwb
reviewed
Jul 11, 2022
ericwb
reviewed
Jul 11, 2022
ericwb
reviewed
Jul 11, 2022
ericwb
reviewed
Jul 11, 2022
ericwb
reviewed
Jul 11, 2022
ericwb
reviewed
Jul 11, 2022
ericwb
reviewed
Jul 11, 2022
ericwb
reviewed
Jul 11, 2022
ericwb
reviewed
Jul 11, 2022
ericwb
reviewed
Jul 11, 2022
ericwb
reviewed
Jul 11, 2022
ericwb
reviewed
Jul 11, 2022
ericwb
reviewed
Jul 11, 2022
ericwb
reviewed
Jul 11, 2022
ericwb
reviewed
Jul 11, 2022
ericwb
reviewed
Jul 11, 2022
ericwb
reviewed
Jul 11, 2022
ericwb
reviewed
Jul 11, 2022
ericwb
approved these changes
Jul 11, 2022
Member
ericwb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.