Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Replace pbr in favor of importlib#1016

Merged
ericwb merged 2 commits intoPyCQA:mainfrom
ericwb:importlib
Jun 5, 2023
Merged

Replace pbr in favor of importlib#1016
ericwb merged 2 commits intoPyCQA:mainfrom
ericwb:importlib

Conversation

Copy link
Member

ericwb commented Apr 7, 2023 *
edited
Loading

The importlib module has a metadata.version to retrieve the package version of the given module. This can be used in lieu of pbr for gathering versioning. As a result we can drop the runtime dependency on pbr.

Fixes #839
Fixes #735

The importlib module has a metadata.version to retrieve the package
version of the given module. This can be used in lieu of pbr for
gathering versioning. And since importlib is part of the base
Python package in 3.8 and greater, we can drop another dependency.

Closes PyCQA#839

Signed-off-by: Eric Brown
Signed-off-by: Eric Brown
ericwb requested review from lukehinds and sigmavirus24 as code owners April 7, 2023 04:34
ericwb mentioned this pull request Apr 7, 2023
Copy link
Member Author

ericwb commented Apr 7, 2023

Note: this is a recreated PR of #840. See that PR for initial comments and review.

lukehinds approved these changes Jun 5, 2023
ericwb merged commit 7e909f9 into PyCQA:main Jun 5, 2023
ericwb deleted the importlib branch June 5, 2023 21:23
ericwb mentioned this pull request Jun 6, 2023
oskooi mentioned this pull request Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lukehinds lukehinds approved these changes

sigmavirus24 Awaiting requested review from sigmavirus24 sigmavirus24 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove pbr runtime dependency in favor of importlib.metadata? Pbr is unexpectedly required during runtime

2 participants