-
Notifications
You must be signed in to change notification settings - Fork 75
Stop requiring style-src 'unsafe-inline' CSP#472
Open
kiliancs wants to merge 1 commit intoxobotyi:masterfrom
Open
Stop requiring style-src 'unsafe-inline' CSP#472kiliancs wants to merge 1 commit intoxobotyi:masterfrom
kiliancs wants to merge 1 commit intoxobotyi:masterfrom
Conversation
Description
Addresses #469.
Setting the style attribute on an element violates stricter CSP and requires a policy of style-src 'unsafe-inline'. Setting each style in the style property of the element resolves this issue.
Use case
A safe application with a strict CSP. See https://codesandbox.io/s/autumn-fast-n5p48h?file=/public/index.html and #469 for more details.
Type of change
- Bug fix (non-breaking change which fixes an issue)
Checklist
- Perform a code self-review
- Comment the code, particularly in hard-to-understand areas
- Update/add the documentation
- Write tests
- Ensure the test suite passes (
yarn test) - Provide 100% tests coverage
Addresses xobotyi#171.
Setting the `style` attribute on an element violates stricter CSP and
requires a policy of `style-src 'unsafe-inline'`. Setting each style in
the style property of the element resolves this issue.
Setting the `style` attribute on an element violates stricter CSP and
requires a policy of `style-src 'unsafe-inline'`. Setting each style in
the style property of the element resolves this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.