Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Empty String check#39

Merged
witochandra merged 3 commits intowitochandra:masterfrom
pdahlberg:parse_null_or_empty
Apr 25, 2021
Merged

Empty String check#39
witochandra merged 3 commits intowitochandra:masterfrom
pdahlberg:parse_null_or_empty

Conversation

Copy link
Contributor

pdahlberg commented Dec 21, 2020

What

Checking for empty String when parsing itunes item's duration, episode and season.
Test includes a xml to reproduce the problem.

Why

I stumbled upon a feed (Sam Harris private feed) with an empty duration tag which broke the parser.

pdahlberg marked this pull request as ready for review December 21, 2020 07:49
witochandra merged commit a1c0ba9 into witochandra:master Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants