nullaway/src/main/java/com/uber/nullaway/dataflow/DataFlow.java (1)

173-183: Minor: source level check for diamond in anonymous class.

new Result<>() { ... } requires JDK 9+. If you need to keep source-8 compatibility, expand the type parameters explicitly. Otherwise, ignore.

nullaway/src/main/java/com/uber/nullaway/NullAway.java (1)

2727-2739: Prefer explicit type over var here (source-level compatibility).

Use TreePath explicitly to avoid requiring JDK 10+.

- var invocationPath = TreePath.getPath(path, invocationTree);
+ TreePath invocationPath = TreePath.getPath(path, invocationTree);

What is the current --release/source level for this module?

nullaway/src/main/java/com/uber/nullaway/generics/GenericsChecks.java (4)

1078-1096: Pass invocation path when available (consistency).

You can pass state.getPath() instead of null to improve robustness in nested contexts:

- Type enclosingType = getEnclosingTypeForCallExpression(methodSymbol, tree, null, state, false);
+ Type enclosingType = getEnclosingTypeForCallExpression(methodSymbol, tree, state.getPath(), state, false);

---

1119-1126: Also pass path to inference call.

- inferGenericMethodCallType(
- state,
- (MethodInvocationTree) currentActualParam,
- null,
+ inferGenericMethodCallType(
+ state,
+ (MethodInvocationTree) currentActualParam,
+ state.getPath(),
formalParameter,
false,
false);

---

1563-1570: Pass path when getting parameter nullness at invocation.

- Type enclosingType =
- getEnclosingTypeForCallExpression(invokedMethodSymbol, tree, null, state, false);
+ Type enclosingType =
+ getEnclosingTypeForCallExpression(invokedMethodSymbol, tree, state.getPath(), state, false);

---

3-9: Unify Verify usage/imports (minor).

Use either static import (verify(...)) everywhere or Verify.verify(...), and drop the unused import accordingly.

-import static com.google.common.base.Verify.verify;
-import com.google.common.base.Verify;
+import static com.google.common.base.Verify.verify;

- Verify.verify(isGenericCallNeedingInference(invocationTree));
+ verify(isGenericCallNeedingInference(invocationTree));

- Verify.verify(tree instanceof NewClassTree);
+ verify(tree instanceof NewClassTree);

Also applies to: 567-568, 1617-1619

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro