Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Feature: Tibia Char Bazaar endpoints#24

Draft
tobiasehlert wants to merge 3 commits intomainfrom
feature-char-bazaar
Draft

Feature: Tibia Char Bazaar endpoints#24
tobiasehlert wants to merge 3 commits intomainfrom
feature-char-bazaar

Conversation

Copy link
Member

tobiasehlert commented Jan 4, 2022

This feature includes following endpoints:

  • current auctions
  • auction history
  • auction details

Original PR was #23

tobiasehlert added documentation Improvements or additions to documentation enhancement New feature or request go Pull requests that update Go code labels Jan 4, 2022
Copy link
Contributor

pheizx commented Jan 4, 2022

Working on this. I will have the refactor changes according to SonarCloud Code Analysis soon.

Can we elaborate a bit more on the current auctions and auction history endpoints ?
Are these endpoints going to retrieve only the auctions that appear in the main page or should we add pagination ?

Copy link
Member Author

tobiasehlert commented Jan 4, 2022

Working on this. I will have the refactor changes according to SonarCloud Code Analysis soon.

Can we elaborate a bit more on the current auctions and auction history endpoints ? Are these endpoints going to retrieve only the auctions that appear in the main page or should we add pagination ?

Yeah, there where a couple of notes from SonarCloud so some things should be renamed/rewritten.
But yes, we definitely need pagination so that people can retrieve "all" current and historical auctions.

tobiasehlert force-pushed the feature-char-bazaar branch from dcb1a06 to be534bc Compare January 19, 2022 21:41
Copy link

sonarqubecloud bot commented Jan 19, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #24 (be534bc) into main (ce26e50) will decrease coverage by 8.52%.
The diff coverage is 0.00%.

@@ Coverage Diff @@
## main #24 +/- ##
==========================================
- Coverage 58.38% 49.85% -8.53%
==========================================
Files 21 22 +1
Lines 2595 3039 +444
==========================================
Hits 1515 1515
- Misses 1023 1467 +444
Partials 57 57

tibiadata deleted a comment from sonarqubecloud bot Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation enhancement New feature or request go Pull requests that update Go code

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants