-
Notifications
You must be signed in to change notification settings - Fork 190
fix: ensure browser environment in test-utils#712
Merged
thebuilder merged 4 commits intomainfrom Dec 30, 2024
Merged
Conversation
Owner
This pull request includes several changes to the src/test-utils.ts file to improve the handling of the React act function and IntersectionObserver mocking. The key changes involve refactoring the code to ensure compatibility with different environments and simplifying the logic.
Refactoring for compatibility and simplification:
- Removed the global declarations for
IS_REACT_ACT_ENVIRONMENTandjestinsrc/test-utils.ts, so we don't clash with user type definitions. - Updated the condition to check for
windowbefore setting up IntersectionObserver mocking insrc/test-utils.ts. - Replaced the
getIsReactActEnvironmentfunction withgetActFnto encapsulate the logic for determining the appropriateactfunction insrc/test-utils.ts. - Modified the
triggerIntersectionfunction to use the newgetActFnmethod for invoking theactfunction insrc/test-utils.ts.
|
Run & review this pull request in StackBlitz Codeflow. |
|
The latest updates on your projects. Learn more about Vercel for Git /
|
npm i https://pkg.pr.new/thebuilder/react-intersection-observer@712commit: |
Owner
Author
|
This PR is included in version 9.14.1 The release is available on: Your semantic-release bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.