Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

correct syntax errors in LSP section#69

Open
liushuping wants to merge 1 commit intothangchung:masterfrom
liushuping:LSP
Open

correct syntax errors in LSP section#69
liushuping wants to merge 1 commit intothangchung:masterfrom
liushuping:LSP

Conversation

Copy link
Contributor

liushuping commented Oct 17, 2019

The ShapeBase actually should be RectangleBase
In the Square class, better to set the Width and Height properties as both are protected properties inherited from RectangleBase.

Copy link

dmitryvhf commented Jan 4, 2020

Better fixed is #75

filipbekic01 reacted with rocket emoji

Copy link
Contributor

filipbekic01 commented Jan 13, 2020

I'll fix rest of examples regarding SOLID principles.

Copy link
Contributor

toanvo288 commented Jun 30, 2020

@thangchung : Do you have a chance to have a look at these changes? From my point of view, it good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants