-
Notifications
You must be signed in to change notification settings - Fork 237
fix until does not update when state.property is changed , stays one state behind.#109
Open
pwliuab wants to merge 3 commits intotalalmajali:masterfrom
Open
fix until does not update when state.property is changed , stays one state behind.#109pwliuab wants to merge 3 commits intotalalmajali:masterfrom
pwliuab wants to merge 3 commits intotalalmajali:masterfrom
Conversation
fix until does not update when state.property is changed , stays one state behind.
- adding !this.state.isStartedCountDown and this.props.until !== this.preState.until in componentDidUpdate to check intial update
- one state behind that's because this.props.until == this.preProp.until is always true, intially.
|
im new, how do you pull this as an import CountDown from 'react-native-countdown-component'; ? or do i need to reinstall the whole library but with your branch? how do i achieve that? thank youu |
Author
you can first import the original countdown. Then, you go to the node modules of the original version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.