-
Notifications
You must be signed in to change notification settings - Fork 950
Fix: patch bundled Boost hash.hpp to remove std::unary_function for C++17 compatibility#2749
Closed
Sahilll10 wants to merge 66 commits intosu2code:masterfrom
Closed
Fix: patch bundled Boost hash.hpp to remove std::unary_function for C++17 compatibility#2749Sahilll10 wants to merge 66 commits intosu2code:masterfrom
Sahilll10 wants to merge 66 commits intosu2code:masterfrom
Conversation
Root Cause
boost/container_hash/hash.hpp uses a guard #if defined(_HAS_AUTO_PTR_ETC)
which is MSVC-only. On MacOS/clang and GCC with -std=c++17, this guard never
activates, so hash_base inherits from std::unary_function
which was removed in C++17 -- causing a build failure.
Fix
Patched the #else branch of hash_base in the bundled Boost headers inside
externals/tecio/boost.tar.gz to use explicit typedef declarations instead
of std::unary_function inheritance. This is identical to what the #if branch
already does correctly for MSVC. No behaviour change whatsoever.
Verification
After repacking, confirmed zero occurrences of unary_function remain in
boost/container_hash/hash.hpp.
Files Changed
externals/tecio/boost.tar.gz-- one struct patched inboost/container_hash/hash.hpp
Fixes #2583
Please let me know if there are further adjustments required.
fix eigen direct download url
* fix flame init
Fix MSW scheme with MUSCL
fix for MUSCL ramp start iteration > 0
* fix symmetry shared node
Fix use of DESTDIR with PREFIX in meson
Your Name
and others
added 28 commits
February 14, 2026 00:17
- Changed condition from generic StopCalc flag to specific max_time detection
- CSinglezoneDriver: Detects final_time_reached = (cur_time >= max_time)
- CMultizoneDriver: Applies same pattern for all zones
- Maintains original functionality with clearer, more maintainable code
- Specific to time-domain simulations with second-order time stepping
This addresses maintainer feedback to use explicit time checks instead of
generic stopping conditions, ensuring the fix properly generalizes to all
problem types and follows SU2 monitoring patterns.
- CSinglezoneDriver: Detects final_time_reached = (cur_time >= max_time)
- CMultizoneDriver: Applies same pattern for all zones
- Maintains original functionality with clearer, more maintainable code
- Specific to time-domain simulations with second-order time stepping
This addresses maintainer feedback to use explicit time checks instead of
generic stopping conditions, ensuring the fix properly generalizes to all
problem types and follows SU2 monitoring patterns.
MSW"+" and vectorization
Fixing relaxation factor for conserved turbulent variables in SST model
New tutorial - python wrapper and User Defined Functions
option to duplicate markers, to simplify thermoelastic simulations
Iterate both heat and FEA solvers for thermoelastic simulations
Implement max_time detection in GetCauchyCorrectedTimeConvergence() to delay convergence by one iteration, ensuring both current and previous timesteps are saved to unsteady restart files.
This replaces the previous unsafe solution-swapping approach with a more robust pattern modeled after PR su2code#1237. The delay mechanism leverages existing Cauchy convergence infrastructure and properly handles second-order time stepping.
Fixes su2code#2493
This replaces the previous unsafe solution-swapping approach with a more robust pattern modeled after PR su2code#1237. The delay mechanism leverages existing Cauchy convergence infrastructure and properly handles second-order time stepping.
Fixes su2code#2493
...u2code#2734)
* Moved options for initial guess of density and internal energy for data-driven fluid model to deprecated
* Added initial guess function through a small thermodynamic table and prevent Newton solver processes from getting stuck on bounds of the lookup algorithm
* Simplified expression for speed of sound
* Moved options for initial guess of density and internal energy for data-driven fluid model to deprecated
* Added initial guess function through a small thermodynamic table and prevent Newton solver processes from getting stuck on bounds of the lookup algorithm
* Simplified expression for speed of sound
Fix cli11 cstdint
Adjoint thermo elasticity
...ev-restart
Add functionality for unsteady restart handling in CSinglezoneDriver ...
Add functionality for unsteady restart handling in CSinglezoneDriver ...
Member
|
You opened the PR against the wrong branch, I advise you to read the PR checklist and the contributing guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.