-
Notifications
You must be signed in to change notification settings - Fork 950
Fix build on GCC 13+ by explicitly declaring to CLI11 ; #2740
Closed
gluonparticle wants to merge 1 commit intosu2code:developfrom
Closed
Fix build on GCC 13+ by explicitly declaring to CLI11 ; #2740gluonparticle wants to merge 1 commit intosu2code:developfrom
gluonparticle wants to merge 1 commit intosu2code:developfrom
Conversation
Proposed Changes
GCC 13 and newer removed implicit includes of from standard library headers. This causes the build to fail on modern compilers (like GCC 15 on Arch Linux) when compiling the vendorized CLI11 library due to uint64_t not being defined. This patch explicitly includes in externals/CLI11/CLI11.hpp to restore compatibility without breaking older compilers.
Related Work
Resolves local build failures on rolling-release Linux distributions.
System Information:
- OS: Arch Linux (Kernel 6.18.13-arch1-1)
- Compiler: GCC 15.2.1
Error Log Addressed:
../externals/CLI11/CLI11.hpp:2412:22: error: 'uint64_t' does not name a type
2412 | using result_t = uint64_t;
| ^~~~~~~~
../externals/CLI11/CLI11.hpp:152:1: note: 'uint64_t' is defined in header '
PR Checklist
- I am submitting my contribution to the develop branch.
- My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
- My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
- I used the pre-commit hook to prevent dirty commits and used
pre-commit run --allto format old commits. (Note: Skipped as this is a 1-line fix to a 3rd-party vendor file) - I have added a test case that demonstrates my contribution, if necessary.
- I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary;
GCC 13 and newer removed implicit includes of from standard library headers. This causes the build to fail on modern compilers (like those on Arch Linux) when compiling the vendorized CLI11 library due to uint64_t not being defined. This patch explicitly includes in externals/CLI11/CLI11.hpp to restore compatibility;
Member
|
see #2735 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.