-
Notifications
You must be signed in to change notification settings - Fork 950
Fix clang warnings in CNSSolver.cpp#2716
Conversation
This PR fixes clang and clang-tidy warnings in CNSSolver.cpp.
Unused includes were removed where applicable, and std::endl usages were
replaced to address performance warnings. The inclusion of
CFVMFlowSolverBase.inl is intentionally preserved for explicit template
instantiation, with a local suppression added to handle the clang
unused-includes warning.
No solver logic or numerical behavior is changed.
| If the first point off the wall is in the turbulent region (mu_t/mu_l > 0.1), | ||
| the linear temperature gradient assumption is inaccurate. ---*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please cite a paper that states this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, thanks for flagging this.
This is a known limitation of wall-function-based heat transfer models when the first off-wall point lies in the fully turbulent region. For example, see Kader (1981) and Launder & Spalding (1974), which discuss that linear temperature profiles are only valid within the near-wall region and break down when y+ is too large.
I can add an explicit reference in the comment or rephrase it to make the assumption more precise if you prefer.
|
This looks like more AI slop. Join the slack channel and come a developer meeting introduce yourself if you are actually interested in contributing. |
|
Understood -- thanks for the feedback. I'll join the Slack and take some time to understand the project workflow and expectations before contributing further. |