Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added Line Separator Override Feature to ExtractedTextFormatter#1914

Closed
Lee-WonJun wants to merge 2 commits intospring-projects:mainfrom
Lee-WonJun:fix/extractedtextformatter-line-separator
Closed

Added Line Separator Override Feature to ExtractedTextFormatter#1914
Lee-WonJun wants to merge 2 commits intospring-projects:mainfrom
Lee-WonJun:fix/extractedtextformatter-line-separator

Conversation

Copy link
Contributor

Lee-WonJun commented Dec 12, 2024

about #1913

Changes
Added the ability to override the Line Separator in ExtractedTextFormatter. The default remains System.lineSeparator() to ensure backward compatibility.

Background
Relying on System.lineSeparator() has caused unexpected behavior in different environments. Specifically, while PDF files generally use \n as a line separator regardless of the operating system, Windows environments use \r\n as the default System.lineSeparator(). This discrepancy could lead to formatting failures.

My Thoughts
I reviewed related issues and noticed that Line Separator behavior varies significantly depending on the operating system and environment.
To provide a flexible solution that maintains backward compatibility, I implemented an override option to let developers customize the Line Separator based on their needs.

If you have other better ideas, I'd love to discuss them together.

Lee-WonJun added 2 commits December 12, 2024 17:54
Use overrideLineSeparator for Windows text context.
markpollack assigned sobychacko Dec 20, 2024
Copy link
Contributor

sobychacko commented Dec 21, 2024

Merged via 636f3ae.

sobychacko closed this Dec 21, 2024
Copy link
Contributor Author

Lee-WonJun commented Dec 22, 2024

great! thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

sobychacko

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants