-
-
Notifications
You must be signed in to change notification settings - Fork 781
Abstract routing API sorts routes.#1941
Abstract routing API sorts routes.#1941BorekZnovustvoritel wants to merge 2 commits intospec-first:mainfrom
Conversation
Fixes #1879.
Changes proposed in this pull request:
- This PR is based on comments in PR Sort routes in RoutingMiddleware #1898
- Fix moved from
RoutingMiddlewaretoAbstractRoutingAPI
Let me know if anything else needs adjustments.
|
Just an FYI that I've confirmed this fixes routing bugs in connexion that exist today. For example, attempt to add these 2 routes: paths:In 3.1.0 Not sure if there's more needed in this PR to get it merged but we've had to fork connexion until it will be as LMK if I can help out with some test cases or whatever to get this rolling. CC: @RobbeSneyders |
|
@dkoston adding a test would be very much appreciated and will prevent us from accidentally breaking the behavior in the future. |
|
@RobbeSneyders is there any documentation on how to run the test suite? I added some tests but running the lines from .github/workflows/pipline.yml results in pip install --upgrade pip |
@RobbeSneyders @jmcs LMK if you have some docs on how to run the test suite locally and I'll get these tests completed. Thanks! |