-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
When I use this plugin , I can't fill the data straightly into the target object . I add the isStraight into @Mapping annotation and change the _targetToSource method . I just change the implement way , not to change the content. So it has created the all previous example successfully after my test.
It makes we can straightly fill the data into the target as the field , we don't need to package the parameter as the function or bean when we are in the easy situation. The example is the the dog_example folder.
smotastic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SkyeVaccu
I really like the feature here, and it is a good addition.
Sorry for the late review though, was really busy :(
Just some small things to think about
| Expression generateSourceFieldAssignment(SourceAssignment sourceAssignment, | ||
| ClassElement abstractMapper, VariableElement targetField) { | ||
| Expression generateSourceFieldAssignment( | ||
| SourceAssignment sourceAssignment, ClassElement abstractMapper, VariableElement targetField) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, as already mentioned in your E-Mail (sorry for the late reply :(), would be nice if we could keep the original formatting (for now).
I am not sure if it is possible to configure the formatter on project level, but maybe this would be a good idea to try, as this would avoid the clash of different formatters when collaborating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am so sorry. I change the code formatting too much. If we can come to a consensus view about this idea. I will change the pr and keep the origin formatting.