-
Notifications
You must be signed in to change notification settings - Fork 597
Open
Conversation
- fix many clippy warnings
warning: `mini-lsm` (lib test) generated 16 warnings (11 duplicates) (run `cargo clippy --fix --lib -p mini-lsm --tests` to apply 5 suggestions)
warning: hiding a lifetime that's elided elsewhere is confusing
--> mini-lsm-mvcc/src/tests/harness.rs:76:12
|
76 | fn key(&self) -> KeySlice {
| ^^^^^ ^^^^^^^^ the same lifetime is hidden here
| |
| the lifetime is elided here
|
= help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
|
76 | fn key(&self) -> KeySlice<'_> {
| ++++
warning: `mini-lsm-mvcc` (lib test) generated 17 warnings (12 duplicates) (run `cargo clippy --fix --lib -p mini-lsm-mvcc --tests` to apply 5 suggestions)
Signed-off-by: StandingMan
skyzh
approved these changes
Dec 18, 2025
Owner
skyzh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! time to bump my rust compiler..
Signed-off-by: StandingMan
Signed-off-by: StandingMan
Standing-Man
commented
Dec 18, 2025
| [book] | ||
| authors = ["Alex Chi Z"] | ||
| language = "en" | ||
| multilingual = false |
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @skyzh, I passed the CI checks locally, but I'm not sure why it failed on the remote.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.