-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
tests/ui/extern: add annotations for reference rules#153546
Open
DanielEScherzer wants to merge 1 commit intorust-lang:mainfrom
Open
tests/ui/extern: add annotations for reference rules#153546DanielEScherzer wants to merge 1 commit intorust-lang:mainfrom
DanielEScherzer wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
A-docs
Area: Documentation for any part of the project, including the compiler, standard library, and tools
labels
Mar 7, 2026
ehuss
reviewed
Mar 10, 2026
| @@ -1,3 +1,4 @@ | |||
| //@ reference: items.extern.static.safety | |||
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this hits items.extern.static.safety, I think the primary thing this is trying to cover is that a static initializer cannot access extern statics. That is defined in const-eval.const-expr.path-static so I would add that here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.