-
-
Notifications
You must be signed in to change notification settings - Fork 241
Remove Dir.chdir for thread-safety#397
Open
lovro-bikic wants to merge 1 commit intorubysec:masterfrom
Open
Conversation
Currently, Bundler::Audit::Database#update!, #commit_id and #last_updated_at fail in multi-threaded environments (like background processing jobs) because they use Dir.chdir.
From Ruby docs on Dir.chdir:
In a multi-threaded program an error is raised if a thread attempts to open a chdir block while another thread has one open, or a call to chdir without a block occurs inside a block passed to chdir (even in the same thread).
This PR removes the need for Dir.chdir by using Open3.capture2 from the stdlib with the chdir option.
External behavior should stay the same: Dir.chdir raises an Errno::ENOENT error given an non-existent directory, and the same holds with the new implementation.
Fixes #156
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.