-
Notifications
You must be signed in to change notification settings - Fork 200
Add JSONValue and UncheckedSendable#736
Merged
mickael-menu merged 18 commits intoreadium:developfrom Mar 4, 2026
Merged
Conversation
mickael-menu
reviewed
Mar 3, 2026
stevenzeck
commented
Mar 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces new Swift 6-migration helpers to replace untyped JSON (Any) with a type-safe JSONValue, plus an UncheckedSendable wrapper to ease Sendable adoption.
Changes:
- Add
JSONValue(Sendable/Hashable, literals, Codable) andReadResultJSON decoding helpers returningJSONValue. - Add
UncheckedSendablewrapper for explicitly opting into@unchecked Sendable. - Add unit tests for
JSONValueand update Carthage/Xcode project generation files to include the new sources.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/SharedTests/Toolkit/JSONValueTests.swift | Adds test coverage for JSONValue initialization, literals, Codable, and decoding helpers. |
| Sources/Shared/Toolkit/JSONValue.swift | Introduces the type-safe JSON representation and conversions from Any, plus literal/Codable conformances. |
| Sources/Shared/Toolkit/UncheckedSendable.swift | Adds a wrapper type to force Sendable conformance when the caller guarantees thread-safety. |
| Sources/Shared/Toolkit/JSON.swift | Adds ReadResult-style helpers to decode Data/Data? into JSONValue / object dictionaries. |
| Support/Carthage/Readium.xcodeproj/project.pbxproj | Includes the new Swift source files in the Carthage Xcode project build. |
| Support/Carthage/.xcodegen | Updates the XcodeGen input list (currently includes unwanted .DS_Store paths). |
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.