-
Notifications
You must be signed in to change notification settings - Fork 200
Generate AccessibilityDisplayString from thorium-locales#708
Merged
mickael-menu merged 4 commits intodevelopfrom Jan 28, 2026
Merged
Generate AccessibilityDisplayString from thorium-locales#708mickael-menu merged 4 commits intodevelopfrom
AccessibilityDisplayString from thorium-locales#708mickael-menu merged 4 commits intodevelopfrom
Conversation
Member
Changed
Shared
- Accessibility display strings are now sourced from the thorium-locales repository (instead of W3C's repository). Contributions are welcome on Weblate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates accessibility display strings from the W3C's publ-a11y-display-guide-localizations repository to the EDRLab's thorium-locales repository, enabling community contributions through Weblate. The change includes refactoring the localization generation scripts and updating the key naming conventions.
Changes:
- Replaced W3C accessibility localization source with thorium-locales repository
- Refactored build scripts to consolidate locale generation under a single
convert-thorium-localizations.jsscript - Updated locale structure from
en-US.lprojtoen.lprojand added Italian (it) translations
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
BuildTools/Scripts/generate-a11y-extensions.js |
New script to generate Swift extensions from localization keys |
BuildTools/Scripts/convert-thorium-localizations.js |
Refactored to support both LCP and accessibility localizations with new a11y project configuration |
BuildTools/Scripts/convert-a11y-display-guide-localizations.js |
Removed (replaced by convert-thorium-localizations.js) |
Makefile |
Simplified locale update process to use single script and removed W3C-specific commands |
Sources/Shared/Resources/en.lproj/W3CAccessibilityMetadataDisplayGuide.strings |
Relocated from en-US to en and regenerated from thorium-locales |
Sources/Shared/Resources/fr.lproj/W3CAccessibilityMetadataDisplayGuide.strings |
New French translations from thorium-locales |
Sources/Shared/Resources/it.lproj/W3CAccessibilityMetadataDisplayGuide.strings |
New Italian translations from thorium-locales |
Sources/Shared/Publication/Accessibility/AccessibilityDisplayString+Generated.swift |
Regenerated with alphabetically sorted keys and renamed constants |
Sources/Shared/Publication/Accessibility/AccessibilityMetadataDisplayGuide.swift |
Updated to use renamed constants and added fallback logic for strings without compact/descriptive variants |
Tests/SharedTests/Publication/Accessibility/AccessibilityMetadataDisplayGuideTests.swift |
Updated test expectations for renamed constants and added fallback behavior tests |
Support/Carthage/Readium.xcodeproj/project.pbxproj |
Updated Xcode project to reference new locale directories |
Support/Carthage/.xcodegen |
Updated paths from en-US to en/fr/it locales |
CHANGELOG.md |
Documented the change to thorium-locales source |
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sources/Shared/Resources/it.lproj/W3CAccessibilityMetadataDisplayGuide.strings
Show resolved
Hide resolved
Sources/Shared/Resources/fr.lproj/W3CAccessibilityMetadataDisplayGuide.strings
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.