Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

About screen sui#492

Merged
mickael-menu merged 23 commits intoreadium:developfrom
FuzzzzyBoy:about-screen-sui
Oct 22, 2024
Merged

About screen sui#492
mickael-menu merged 23 commits intoreadium:developfrom
FuzzzzyBoy:about-screen-sui

Conversation

Copy link
Contributor

FuzzzzyBoy commented Oct 14, 2024

Recreate about screen with SwiftUI and make it more stylish :)

FuzzzzyBoy mentioned this pull request Oct 14, 2024
KirillUzum added 2 commits October 15, 2024 03:44
Copy link
Member

mickael-menu left a comment *
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR! I left a few comments.

I also had one issue on iPad with iOS 18, the about screen is only displayed when we hit the hamburger menu in the top left:


Image(systemName: iconName)
}
.font(.title2)
.foregroundColor(Color(red: 0.0, green: 0.18, blue: 0.39))
Copy link
Member

mickael-menu Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should avoid using custom colors as they won't work well with iOS upgrades or the dark mode (That includes .foregroundColor(.gray)).

Copy link
Contributor Author

FuzzzzyBoy Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, thanks, fix it

Comment on lines +41 to +43
.background(Color(UIColor.secondarySystemGroupedBackground))
.cornerRadius(10)
.shadow(radius: 2)
Copy link
Member

mickael-menu Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use a GroupBox to get a similar look but native to the platform.

Copy link
Contributor Author

FuzzzzyBoy Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, thanks, fix it

Comment on lines +101 to +104
private extension URL {
static let edrlab = URL(string: "https://www.edrlab.org/")!
static let license = URL(string: "https://opensource.org/licenses/BSD-3-Clause")!
}
Copy link
Member

mickael-menu Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

FuzzzzyBoy reacted with laugh emoji
FuzzzzyBoy added 3 commits October 17, 2024 15:43
Copy link
Contributor Author

FuzzzzyBoy commented Oct 17, 2024

fix iPad layout

Copy link
Contributor Author

FuzzzzyBoy commented Oct 17, 2024

fix iPad layout

Copy link
Contributor Author

FuzzzzyBoy commented Oct 21, 2024 *
edited
Loading

@mickael-menu I think I fix all issues, can you check this MR one more time plz?

mickael-menu approved these changes Oct 22, 2024
Copy link
Member

mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes @FuzzzzyBoy

mickael-menu temporarily deployed to LCP October 22, 2024 12:03 -- with GitHub Actions Inactive
mickael-menu temporarily deployed to LCP October 22, 2024 12:03 -- with GitHub Actions Inactive
mickael-menu had a problem deploying to LCP October 22, 2024 12:05 -- with GitHub Actions Failure
mickael-menu merged commit ef69587 into readium:develop Oct 22, 2024
FuzzzzyBoy deleted the about-screen-sui branch October 23, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mickael-menu mickael-menu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants