-
Notifications
You must be signed in to change notification settings - Fork 51
Add space in the button for clarity #88#95
Open
BlackSou wants to merge 1 commit intopubliclab:mainfrom
Open
Conversation
Fixes #0000 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
- PR is descriptively titled and links the original issue above
- code is in uniquely-named feature branch and has no merge conflicts
- screenshots/GIFs are attached in case of UI updation
- ask
@publiclab/reviewersor the user who published the issue for help, in a comment below
We're happy to help you get this ready -- don't be afraid to ask for help!
Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!
|
Hi @BlackSou , good job on opening your first PR on this repository . Can you please add the issue number this PR resolved and also attach a screenshot of the button with the added space? Happy Contributing |
|
This pull request is outdated and should be moved to pull #96 -- essentially does the same thing with more context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.