-
Notifications
You must be signed in to change notification settings - Fork 16.1k
Conversation
Member
Cherry-pick of 7051cc1
Includes pre-built protoc integrity hashes in the release artifact, in a new file bazel/private/prebuilt_tool_integrity.bzl
tested on my fork of protobuf: https://github.com/alexeagle/protobuf/releases/tag/v0.1000.10
Next steps:
- create toolchain definitions that fetch the prebuilt protoc from github releases
- change logic in Bazel setup to use the prebuilt toolchain when desired
- create a token from @protobuf-team-bot account and add to GHA secrets so the pull request to BCR opens
Closes #23465
COPYBARA_INTEGRATE_REVIEW=#23465 from protocolbuffers:alexeagle/bazel-protoc-prebuilt 05314db PiperOrigin-RevId: 817227717
Includes pre-built protoc integrity hashes in the release artifact, in a new file `bazel/private/prebuilt_tool_integrity.bzl`
tested on my fork of protobuf: https://github.com/alexeagle/protobuf/releases/tag/v0.1000.10
Next steps:
- create toolchain definitions that fetch the prebuilt protoc from github releases
- change logic in Bazel setup to use the prebuilt toolchain when desired
- create a token from @protobuf-team-bot account and add to GHA secrets so the pull request to BCR opens
Closes #23465
COPYBARA_INTEGRATE_REVIEW=#23465 from protocolbuffers:alexeagle/bazel-protoc-prebuilt 05314db
PiperOrigin-RevId: 817227717
tested on my fork of protobuf: https://github.com/alexeagle/protobuf/releases/tag/v0.1000.10
Next steps:
- create toolchain definitions that fetch the prebuilt protoc from github releases
- change logic in Bazel setup to use the prebuilt toolchain when desired
- create a token from @protobuf-team-bot account and add to GHA secrets so the pull request to BCR opens
Closes #23465
COPYBARA_INTEGRATE_REVIEW=#23465 from protocolbuffers:alexeagle/bazel-protoc-prebuilt 05314db
PiperOrigin-RevId: 817227717
Member
Author
|
@alexeagle FYI |
mkruskal-google
reviewed
Oct 10, 2025
mkruskal-google
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.