-
Notifications
You must be signed in to change notification settings - Fork 29
Adding bibliography/bibref elements to indexers and catalog views#1505
Adding bibliography/bibref elements to indexers and catalog views#1505randalldfloyd wants to merge 1 commit intomainfrom
Conversation
Closes #1458
Adding missing bibliography elements from collection and component indexers, and also to catalog views.
Per feedback on #1458, this solution skips over potentially elaborate bibliography text and just creates lists from child bibref elements instead. It also scopes them to occurrences within bibliography elements only, versus the many places they can technically exist outside of them.
f250c71 to
f214f77
Compare
seanaery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is close but it looks like it is not rendering the italic formatting despite using the render_html_tags helper. A couple recommended revisions to that end:
- All the fields that we're indexing where we're retaining the EAD tags for transformation to HTML should have a
_html_tesmsuffix, so this should bebibref_html_tesm. To keep the tags in there, the traject rule also needsto_text: false(else it will strip all tags and just keep the text).
|
Thanks @seanaery , I never really knew how those html fields worked, so that was a good opportunity to figure that out. After reworking indexing to preserve html, they are displaying correctly and passing refactored tests. The italic sections are now being rendered with At first I thought they were being stashed as one value in the Solr field, but I verified that they are each in an array element: ["I would have thought that just being multi-valued would be enough to ensure they are rendered on separate lines. Normally I would figure it out for myself, but I'm technically off this week so any shortcuts you could point me to would be great. |
f214f77 to
62f0640
Compare