-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Comments
fix: prevent browser freeze when tessellating >50k vertices (#8219 )#8555
Open
Nixxx19 wants to merge 1 commit intoprocessing:mainfrom
Open
fix: prevent browser freeze when tessellating >50k vertices (#8219 )#8555Nixxx19 wants to merge 1 commit intoprocessing:mainfrom
Nixxx19 wants to merge 1 commit intoprocessing:mainfrom
Conversation
Resolves #8219
Changes:
- Added vertex count validation in
_processVertices()before calling_tesselateShape()to prevent browser freeze - Shows friendly warning message when vertex count exceeds 50,000 vertices
- Skips tessellation for large shapes and falls back to
TRIANGLE_FANmode so shapes still render - Added unit tests to verify warning behavior and normal operation for safe vertex counts
The fix prevents the browser from freezing when libtess tries to tessellate shapes with >65k vertices. The freeze was happening inside libtess during _triangulate(), before any buffer caching logic could run.
Screenshots of the change:
PR Checklist
-
npm run lintpasses - [Inline reference] is included / updated (not applicable - this is a bug fix)
- [Unit tests] are included / updated
|
Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors! Thank You! |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.