Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix precommit hooks#725

Merged
MakisH merged 1 commit intoprecice:developfrom
PranjalManhgaye:fix-precommit-hooks
Feb 25, 2026
Merged

Fix precommit hooks#725
MakisH merged 1 commit intoprecice:developfrom
PranjalManhgaye:fix-precommit-hooks

Conversation

Copy link
Contributor

PranjalManhgaye commented Feb 25, 2026 *
edited
Loading

this PR addresses #707 and adjusts how our validation scripts behave during pre-commit checks.

Summary

at the moment, scripts like check-image-names.py, check.sh, and check-size.sh also pick up untracked local files. This can cause pre-commit to fail even when those files aren't part of the repository.

With this change, the scripts now only operate on files that are actually tracked by Git. Untracked local files are ignored.

Changes

  • check-image-names.py now determines tracked files using git ls-files and skips anything untracked.
  • check.sh and check-size.sh have been updated to validate only Git-tracked files.

This keeps the naming and size checks strict for repository content, while avoiding unnecessary failures caused by local development files.

Impact

  • pre-commit no longer fails because of untracked local files.
  • Naming and size rules are still enforced for all tracked content.
  • The workflow becomes less frustrating for contributors without reducing repository standards.

Checklist

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

Copy link
Member

MakisH commented Feb 25, 2026

@PranjalManhgaye thanks for the contribution! It looks like you included some commits from another branch that were not meant to be here. Could you please sort out the history and push again?

MakisH added the GSoC Contributed in the context of the Google Summer of Code label Feb 25, 2026
Copy link
Contributor Author

PranjalManhgaye commented Feb 25, 2026 *
edited
Loading

sure , thanks @MakisH for pointing that out. I accidentally branched fix-precommit-hooks off fix-clean-scripts, so the pr included unrelated systemtest/cleaning commits.

MakisH reacted with thumbs up emoji

PranjalManhgaye force-pushed the fix-precommit-hooks branch from 5ee20fe to 579ed2e Compare February 25, 2026 09:22
MakisH approved these changes Feb 25, 2026
Copy link
Member

MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked locally for:

  • markdown issues on untracked (and tracked) files
  • image names on untracked (and tracked) images
  • image size on untracked (and tracked) images

all work as expected. Thanks!

PranjalManhgaye reacted with heart emoji
MakisH merged commit 0ebc834 into precice:develop Feb 25, 2026
1 check passed
Copy link
Contributor Author

PranjalManhgaye commented Feb 26, 2026 *
edited
Loading

@MakisH looks like the pre-commit check failed due to markdownlint npm install (403). let me know if I should open a fix or re-run,
is it a dependency download issue ?

Copy link
Member

MakisH commented Feb 26, 2026

All good, triggered it again, worked.

PranjalManhgaye reacted with thumbs up emoji

Copy link
Collaborator

precice-bot commented Mar 8, 2026

This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there:

https://precice.discourse.group/t/gsoc-2026-pranjal-manhgaye/2769/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

MakisH MakisH approved these changes

Assignees

No one assigned

Labels

GSoC Contributed in the context of the Google Summer of Code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants