-
-
Notifications
You must be signed in to change notification settings - Fork 155
Conversation
Running pre-commit in the tutorials edits those files. Am I the only one?
Checklist:
- I added a summary of any user-facing changes (compared to the last release) in the
changelog-entries/..md - I will remember to squash-and-merge, providing a useful summary of the changes of this PR.
and as a side note: the other pre-commit also fails constantly for me:
- hook id: check-names
- exit code: 1
No, you are not the only one. I already noticed this. |
MakisH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, that's strange. pre-commit passes on my system already with develop, and it has so far been passing on GitHub Actions as well.
Maybe it is related to the Python version.
But since this version passes in all systems, let's keep this one.
@davidscn I see this marked as draft at the moment. Is it ready to merge?
Is there a report on which files fail? It also passes on my system and here. We probably have a bigger issue, if it only works on some systems. |
|
Lengthy report, but it seems that the pre-commit picks up local files not tracked by git in the first place particles-bidirectional/images/tutorials-channel-transport-animation.webm: error: wrong filename |
I opened another issue for that, since that looks independent and lower priority (high effort/low benefit): #707 |