-
Notifications
You must be signed in to change notification settings - Fork 55
more campaign info added in campaign-news service#602
Open
RalitsaIlieva wants to merge 1 commit intopodkrepi-bg:masterfrom
Open
more campaign info added in campaign-news service#602RalitsaIlieva wants to merge 1 commit intopodkrepi-bg:masterfrom
RalitsaIlieva wants to merge 1 commit intopodkrepi-bg:masterfrom
Conversation
The change was made because I need more info about the campaign in the news section where a new frontend is prepared
Motivation and context
Testing
Steps to test
New endpoints
Environment
New environment variables:
-
NEW_ENV_VAR: env var details
New or updated dependencies:
| Dependency name | Previous version | Updated version | Details |
|---|---|---|---|
dependency/name |
v1.0.0 |
v2.0.0 |
|
Tests will run for this PR. Once they succeed it can be merged. |
github-actions
bot
removed
the
run tests
Allows running the tests workflows for forked repos
label
Mar 2, 2024
sashko9807
requested changes
Mar 16, 2024
| @@ -128,12 +128,9 @@ export class CampaignController { | |||
| } | |||
|
|
|||
| @Get('byId/:id') | |||
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This endpoint is for administrators only, and the returned data by it is not meant to be public.
If the goal is to get the donation data of campaign, please use one of the available Public() endpoints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.