-
Notifications
You must be signed in to change notification settings - Fork 379
fix(Table): updated logic for expandable class#11918
Merged
dlabaj merged 2 commits intopatternfly:mainfrom Jul 11, 2025
Merged
Conversation
Contributor
What: Closes #11916
Tested pulling in patternfly/patternfly#7654 (comment) locally with these React updates, in both expandable and compound expandable examples:
- The examples currently on staging work still as expected
- Copying the examples from main (without any of these recent updates where props are being passed in as they should have been) and pasting into examples work as expected
- Same as above bullet point, except also passing in the isExpanded logic to the "control"
Trwork as expected
Additional issues:
Collaborator
|
Preview: https://patternfly-react-pr-11918.surge.sh A11y report: https://patternfly-react-pr-11918-a11y.surge.sh |
mcoker
approved these changes
Jul 10, 2025
rebeccaalpert
approved these changes
Jul 10, 2025
kmcfaul
approved these changes
Jul 11, 2025
dlabaj
approved these changes
Jul 11, 2025
Contributor
dlabaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Collaborator
|
Your changes have been released in:
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.