-
Notifications
You must be signed in to change notification settings - Fork 379
fix(DatePicker): prevented textless helper text from rendering#11713
Merged
wise-king-sullyman merged 2 commits intopatternfly:mainfrom Apr 8, 2025
Merged
fix(DatePicker): prevented textless helper text from rendering#11713wise-king-sullyman merged 2 commits intopatternfly:mainfrom
wise-king-sullyman merged 2 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11713.surge.sh A11y report: https://patternfly-react-pr-11713-a11y.surge.sh |
kmcfaul
approved these changes
Apr 8, 2025
wise-king-sullyman
reviewed
Apr 8, 2025
|
|
||
| await user.click(screen.getByRole('textbox')); | ||
| await user.click(document.body); | ||
| expect(asFragment()).toMatchSnapshot(); |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there not a better assertion you could use here? Maybe something that queries for the helper text?
Eric Olkowski
added 2 commits
April 8, 2025 10:25
thatblindgeye
force-pushed
the
iss11709_datepickerErrorRender
branch
from
April 8, 2025 14:44
9df3381 to
2f42043
Compare
wise-king-sullyman
approved these changes
Apr 8, 2025
Collaborator
wise-king-sullyman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Collaborator
|
Your changes have been released in:
Thanks for your contribution! |
dlabaj
pushed a commit
that referenced
this pull request
Apr 17, 2025
* fix(DatePicker): prevented textless helper text from rendering
* Updated validator assertion
* Updated validator assertion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.