-
Notifications
You must be signed in to change notification settings - Fork 379
chore(DescriptionList): added in drawer demo#11404
chore(DescriptionList): added in drawer demo#11404mfrances17 merged 3 commits intopatternfly:mainfrom
Conversation
|
Preview: https://patternfly-react-pr-11404.surge.sh A11y report: https://patternfly-react-pr-11404-a11y.surge.sh |
nicolethoen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something weird is happening with the RTL switcher in this new demo. If the drawer is already open and I switch to rtl, then it disappears. If it's already closed and I open it in RTL mode, it pushes the content out in a way that it doesn't when not using RTL
mcoker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one little nit on the page section variant
packages/react-core/src/demos/DescriptionList/examples/DescriptionListInDrawer.tsx
Outdated
Show resolved
Hide resolved
|
@nicolethoen nice catch! Looks like that's probably just a bug in core not calculating the translate direction properly in RTL. Filed an issue for that here - patternfly/patternfly#7292 |
mcoker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mfrances17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. There are a couple of exceptions thrown but they only appear to be happening when running in surge, not in the demo docs (occurs for the Basic desc list demo as well).
Also it threw me a bit to see the Open in drawer link with the drawer defaulted to open. Be nice if text would change based on status of drawer open/closed (Close drawer/Open drawer).
|
Small thing related to @mfrances17 point. I think it's okay that the "Open drawer" text doesn't change to "Close drawer" when the drawer is open, but only if you aren't able to click that text again to close it (it looks like you can only click the close X in the drawer itself right now) The only thing that's a little weird is that when you hover over the "Open drawer" text when the drawer is open, it does change to the hover state even though you can't actually click the text (which makes me feel like I should be able to click it) |
f929d17 to
64f6177
Compare
|
@mfrances17 @bekah-stephens updated the demo to make that button dynamic. The text will change based on the drawer state, and clicking it will toggle the drawer rather than only always opening it. |
|
@thatblindgeye Tested the updated demo and the open/close drawer is much more clean and intuitive, well done and thank you! Merging... |
|
Your changes have been released in:
Thanks for your contribution! |
* Removed page section styling
* Updated card button behavior to match state