Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: fix types for number input#10264

Merged
tlabaj merged 1 commit intopatternfly:mainfrom
jonkoops:fix-types-number-input
Apr 19, 2024
Merged

chore: fix types for number input#10264
tlabaj merged 1 commit intopatternfly:mainfrom
jonkoops:fix-types-number-input

Conversation

Copy link
Contributor

jonkoops commented Apr 9, 2024

Refactors the types of the number input so that they will compile when upgrading to TypeScript 5. This is needed to land #10156.

Copy link
Collaborator

patternfly-build commented Apr 9, 2024 *
edited
Loading

mfrances17 approved these changes Apr 15, 2024
Copy link
Contributor

mfrances17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mfrances17 requested a review from tlabaj April 15, 2024 20:10
kmcfaul approved these changes Apr 16, 2024
tlabaj approved these changes Apr 17, 2024
tlabaj merged commit 4b75c6e into patternfly:main Apr 19, 2024
Copy link
Collaborator

patternfly-build commented Apr 19, 2024

Your changes have been released in:

  • @patternfly/react-charts@7.4.0-prerelease.1
  • @patternfly/react-code-editor@5.4.0-prerelease.2
  • @patternfly/react-core@5.4.0-prerelease.2
  • @patternfly/react-docs@6.4.0-prerelease.2
  • @patternfly/react-drag-drop@5.4.0-prerelease.2
  • @patternfly/react-icons@5.4.0-prerelease.1
  • demo-app-ts@5.1.1-prerelease.103
  • @patternfly/react-styles@5.4.0-prerelease.1
  • @patternfly/react-table@5.4.0-prerelease.2
  • @patternfly/react-templates@1.1.0-prerelease.2
  • @patternfly/react-tokens@5.4.0-prerelease.1

Thanks for your contribution!

jonkoops deleted the fix-types-number-input branch April 20, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tlabaj tlabaj approved these changes

kmcfaul kmcfaul approved these changes

+1 more reviewer

mfrances17 mfrances17 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants