Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix bit shift methods to respect byte order#42

Merged
patrickfav merged 1 commit intopatrickfav:masterfrom
gfpeltier:master
Feb 27, 2021
Merged

Fix bit shift methods to respect byte order#42
patrickfav merged 1 commit intopatrickfav:masterfrom
gfpeltier:master

Conversation

Copy link
Contributor

gfpeltier commented Feb 22, 2021

Closes #41. Bytes.leftShift and Bytes.rightShift now behave as expected
based on the set byte order.

Closes patrickfav#41. Bytes.leftShift and Bytes.rightShift now behave as expected
based on the set byte order.
patrickfav approved these changes Feb 27, 2021
patrickfav merged commit d737c25 into patrickfav:master Feb 27, 2021
Copy link
Owner

patrickfav commented Feb 27, 2021

Thx for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

patrickfav patrickfav approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bit shift operators do not account for endianness

2 participants